Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added collection-config-file #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pushkarsharma
Copy link
Collaborator

@pushkarsharma pushkarsharma commented Dec 15, 2022

Description
The new command line argument --collection-config-file is added for the config file name that needs to be passed to debug enable/clean-up stages. It is used to indicate whether the collector is enabled or not. The usage of this argument is at https://wwwin-github.cisco.com/cafy/cafykit/blob/a75ac367550d55e7b2db2430d0b05969a01534eb/test/utils/collectors/collector_test.py#L21
Example file:

{
    "lsan": {
        "enabled": true
    },
    "yang": {
        "enabled": true
    },
    "debug": {
        "enabled": true
    }
}

Tests
The following tests executed in the pipeline utilizes this new argument and generates a file in preprocess stage:
(Debug, LSAN, Yang): http://ott-idt-jenk1:8080/view/pushkash/job/pushkash_test_cafyap_pipeline/113/console
Legacy Submitted Run: http://ott-idt-jenk1:8080/view/pushkash/job/pushkash_test_cafyap_pipeline/116/console

@shreyashah
Copy link
Collaborator

Could you please provide PR description and logs

@pushkarsharma
Copy link
Collaborator Author

Could you please provide PR description and logs

I have added that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants