🥅 Handle empty text for filtered span classification #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
evaline-ju
requested review from
alex-jw-brooks,
gkumbhat,
gabe-l-hart,
tharapalanivel and
Ssukriti
as code owners
gkumbhat
reviewed
Jan 17, 2024
| if threshold is None: | ||
| threshold = self.default_threshold | ||
| if text == "": |
There was a problem hiding this comment.
is there a reason to not throw error on this? is that for compatibility with TGIS?
There was a problem hiding this comment.
yes as noted in the PR description the current usage is usually to send generated text (from TGIS) directly to classification
There was a problem hiding this comment.
NIT: Is it worth just using the native "truthiness" of text here (if not text)?
Signed-off-by: Evaline Ju <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return empty classification results when classification is invoked with empty text or empty text stream. This would prevent potential further errors that may incur if any models used (tokenizers or classifiers cannot handle empty strings properly). Empty text could have been considered an error but based on current usage this would not be a desired user experience