✨ Add tokenization task to generation modules #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
evaline-ju
requested review from
alex-jw-brooks,
gkumbhat,
gabe-l-hart,
tharapalanivel and
Ssukriti
as code owners
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
gkumbhat
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #350
Because
TextGenerationTGISis not a subclass but a backend type forTextGeneration, any additional tasks declared on the former were not actually getting added. By adding the additional tasks onTextGenerationandPeftPromptTuningrespectively, this allows the tokenization tasks to be available on the TGIS backend implementations. Unimplemented functions have to be added or there will be errors.Tokenization run functions could eventually be implemented since each LLM could be reasonably expected to have a tokenizer.
Stdgetting imported withLaunchConfigstarted to error in latest torch2.3.0. It was observed theStdobject is at https://github.com/pytorch/pytorch/blame/main/torch/distributed/elastic/multiprocessing/api.py and not in theLaunchConfigand was potentially getting imported through another import to the launcher api.teeis no longer an arg onLaunchConfig. Since this was a breaking change, torch is now pinned below2.3.0.