-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graph mode to embedding models which benefits from ipex optimize #359
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @devpramod ...
Couple of small housekeeping related comments for the PR:
- Can you rebase the PR with a
sign-off
, this allows github to verify and the DCO check would pass. - It seems the lint and formatting checks are failing. Can you please address those.
Guidelines for contribution documenting some of these steps can be found here: https://github.com/caikit/caikit-nlp/blob/main/CONTRIBUTING.md
On the graphmode integration, couple of question and suggestions:
- When should the graph model be enabled? Can you add describe a bit when it is applicable, for which models etc ?
- How much of speedup is expected with enablement of
graphmode
? Can you share some results ?
Hi @gkumbhat
working on addressing 1 & 2 |
Signed-off-by: devpramod <[email protected]>
Signed-off-by: devpramod <[email protected]>
Signed-off-by: devpramod <[email protected]>
Hi @gkumbhat |
Signed-off-by: devpramod <[email protected]>
Graph mode (torchscript) is an additional step that can further accelerate a workload that has been optimized with ipex and bfloat16 along with mixed precision. Graph mode utilizes AMX on SPR for additional speedups.
This PR modifies config file to have
graphmode
as an option to end usersThe graph is compiled in the constructor of the embedding module such that it is ready for execution when requests arrive.