Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#25) Suggested changes after upgrading Cake.Recipe to 2.x #26

Merged
merged 9 commits into from
Jul 15, 2024

Conversation

nils-a
Copy link
Contributor

@nils-a nils-a commented Jul 15, 2024

Description

  • Switch to releasing on GH-Actions
  • disable posting to gitter
  • disable codecov
  • update GRM to the newest 0.18.0
  • add settings.json for vscode
  • Remove usage of nuspec file(s) for NuGet packages
  • Add Cake.Addin.Analyzer package
  • Add CakeContrib.Guidelines Nuget Package
    • fixed CCG0008
    • disabled CCG0009
    • fixed CCG0005
  • Enable deterministic builds

Related Issue

fixes #25

Motivation and Context

#25

How Has This Been Tested?

manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    Build

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

nils-a added 9 commits July 15, 2024 08:12
also:
- disable posting to gitter
- disable codecov
- update GRM to the newest 0.18.0
This automatically solves:
Use embedded icon for NuGet package
by adding a reference to stylecop

- Also, added a stylecop.json and .editorconfig
- Fixed all stylecop issues in the code (mostly documentation)
- Exempted LitJson from all rules, by liberally sprinkling pragmas.
@nils-a nils-a merged commit 873f1bc into cake-contrib:develop Jul 15, 2024
3 checks passed
@nils-a nils-a deleted the feature/GH-25 branch July 15, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement suggested Changes from Cake.Recipe update 2.x
1 participant