Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mweb enhancements 3 #1744

Merged
merged 41 commits into from
Oct 19, 2024
Merged

Mweb enhancements 3 #1744

merged 41 commits into from
Oct 19, 2024

Conversation

fossephate
Copy link
Contributor

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

OmarHatem28 and others added 14 commits September 28, 2024 09:54
@OmarHatem28
version 4.20.0
a552cc3
@OmarHatem28
Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …
0107eb9 
…v4.20.0
@OmarHatem28
update build numbers
28f5702
@OmarHatem28
UI updates and script fix for ios bundle identifier
9afa89f
@OmarHatem28
disable mweb for desktop
2297fa9
@OmarHatem28
change hardcoded ltc server ip address
be76544 
electrum connection enhancement
@fossephate @Blazebrain @OmarHatem28
MWEB enhancements 2.0 (#1735)
7f66dc5 
* additional logging and minor fixes

* additional logging and minor fixes

* addresses pt.1

* Allow Wallet Group Names to be the same as Wallet Names (#1730)

* fix: Issues with imaging

* fix: Allow group names to be the same as wallet names

* fix: Bug with wallet grouping when a wallet is minimized

* fix: Bug with wallet grouping when a wallet is minimized

* logs of fixes and experimental changes, close wallet before opening next

* save

* fix icon

* fixes

* [skip ci] updates

* [skip ci] updates

* updates

* minor optimizations

* fix for when switching between wallets

* [skip ci] updates

* [skip ci] updates

* Update cw_bitcoin/lib/litecoin_wallet.dart

Co-authored-by: Omar Hatem <[email protected]>

* Update cw_bitcoin/lib/litecoin_wallet.dart

Co-authored-by: Omar Hatem <[email protected]>

* mobx

* mostly logging

* stream fix pt.1 [skip ci]

* updates

* some fixes and enhancements

* [skip ci] minor

* potential partial fix for streamsink closed

* fix stream sink closed errors

* fix mweb logo colors

* save

* minor enhancements [skip ci]

* save

* experimental

* minor

* minor [skip ci]

---------

Co-authored-by: David Adegoke <[email protected]>
Co-authored-by: Omar Hatem <[email protected]>
@OmarHatem28
Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …
fd4ba0e 
…v4.20.0_rc2

# Conflicts:
#	cw_bitcoin/lib/electrum_wallet.dart
@OmarHatem28
fix menu list removing from original list
0bfdcbf
@fossephate
detach sync status from mwebsyncstatus
52158e9
@fossephate
minor
e1d3dd3
@fossephate
keep sync status in sync where necessary
f4b1dd8
@fossephate
minor
1f3ee94
@fossephate
wip
45482dc
@OmarHatem28 OmarHatem28 changed the base branch from main to v4.20.0_rc2 October 11, 2024 18:54
Base automatically changed from v4.20.0_rc2 to main October 12, 2024 23:13
OmarHatem28
OmarHatem28 reviewed Oct 14, 2024
View reviewed changes
cw_bitcoin/lib/electrum_wallet.dart Outdated Show resolved Hide resolved
cw_bitcoin/lib/electrum_wallet.dart Outdated Show resolved Hide resolved
OmarHatem28
OmarHatem28 requested changes Oct 17, 2024
View reviewed changes
cw_bitcoin/lib/electrum_wallet.dart Outdated Show resolved Hide resolved
cw_mweb/lib/cw_mweb.dart Show resolved Hide resolved
cw_bitcoin/lib/litecoin_wallet.dart Outdated Show resolved Hide resolved
cw_bitcoin/lib/litecoin_wallet.dart Outdated Show resolved Hide resolved
fossephate and others added 15 commits October 17, 2024 11:28
@fossephate
fix change address on send ui
76b7fcd
@fossephate
fix qr code scan issue
c6efe0e
@OmarHatem28
get segwit address for pegout even if mweb is selected on the receive…
0ab1309 
… screen [skip ci]
@OmarHatem28
- Fix adding nodes twice
2d09f07 
- Fix mempool API parsing error
@fossephate
(potentially) fix duplicate tx history bug
233d310
@fossephate
Merge branch 'mweb_enhancements_3' of https://github.com/cake-tech/ca…
13075a4 
…ke_wallet into mweb_enhancements_3
@fossephate
Merge branch 'main' into mweb_enhancements_3
32a7b53
@fossephate
[skip ci] fix bc1 address
3a39558
@fossephate
Merge branch 'mweb_enhancements_3' of https://github.com/cake-tech/ca…
352c4b3 
…ke_wallet into mweb_enhancements_3
@fossephate
don't show contacts prompt on pegin/out + potential unconfirmed balan…
f264fd3 
…ce fixes
@fossephate
[skip ci] minor cleanup
079f909
@fossephate
fix mweb input detection
328642b
@OmarHatem28
Merge branch 'main' into mweb_enhancements_3
1f70f3d
@fossephate
fix showing mweb address for non-mweb transactions
c3d5e79
@fossephate
Merge branch 'mweb_enhancements_3' of https://github.com/cake-tech/ca…
dee0685 
…ke_wallet into mweb_enhancements_3
@OmarHatem28 OmarHatem28 merged commit 50825a6 into main Oct 19, 2024
2 checks passed
@OmarHatem28 OmarHatem28 deleted the mweb_enhancements_3 branch October 19, 2024 00:05
@OmarHatem28 OmarHatem28 restored the mweb_enhancements_3 branch October 22, 2024 11:12
@OmarHatem28 OmarHatem28 deleted the mweb_enhancements_3 branch October 22, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarHatem28 OmarHatem28 OmarHatem28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fossephate @OmarHatem28 @tuxpizza