Cw 853 mweb utxos are not displayed in coin control screen #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarHatem28
requested changes
Dec 12, 2024
cw_bitcoin/lib/electrum.dart
Outdated
|
|
||
| return <String, dynamic>{}; | ||
| }).toList(); | ||
| if (result == null) throw Exception('Failed to get listunspent'); |
There was a problem hiding this comment.
this will have side effects
ex:
- it's called in a
Future.wait, so, throwing an exception would cause the whole Future.wait to fail - the second place it's called, has a try and catch, but it will make it not continue the flow
- and also would make it report that error to the user through the send error report popup, thus giving the support more unnecessary tickets for connection issues
cw_bitcoin/lib/electrum_wallet.dart
Outdated
Comment on lines
1453
to
1455
| } catch (_) { | ||
| rethrow; | ||
| } |
There was a problem hiding this comment.
I don't think we should rethrow while it's not handled correctly, and will just show the send error report popup to the user
OmarHatem28
approved these changes
Dec 14, 2024
OmarHatem28
deleted the
CW-853-MWEB-utxos-are-not-displayed-in-coin-control-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist