Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decred: Add used address history. #1941

Open
wants to merge 9 commits into
base: decred-updated-main
Choose a base branch
from

Conversation

JoeGruffins
Copy link

Part of #1938

This adds an address history. Currently very simple but can be built upon if necessary.

It changes the sync check back to 5 seconds while syncing only. I feel like 30 seconds is rather long in the beginning. Hope this is alright.

It reverts wisdom's pubspec changes, they tell me the downgrade was a problem with their flutter version after all. Also added testnet by them which can be used for testing, I can provide testnet funds please message.

There were some formatting errors apparently, although I thought I had been updating those.

@JoeGruffins
Copy link
Author

I guess the formatting problem is on our side. I am using dart format but I guess this is not correct, what command should I use?

Also, there is currently a problem with wallet groups. Because of putting the birthday in the mnemonic, we are unfortunately not compatible with other wallets atm...

@JoeGruffins JoeGruffins changed the title Updateaddresses decred: Add used address history. Jan 6, 2025
@JoeGruffins
Copy link
Author

Added another commit. We do use the bip39 word list, which is what I think this is about.

@JoeGruffins
Copy link
Author

JoeGruffins commented Jan 7, 2025

It looks like we have a bug in wallet upstream that has been fixed but may cause sync to stop at the very end. I will update the dcrwallet dep to include this. relevant pr decred/dcrwallet#2445

@JoeGruffins JoeGruffins force-pushed the updateaddresses branch 2 times, most recently from ba5854e to a7266c2 Compare January 7, 2025 08:48
@JoeGruffins
Copy link
Author

Now formatted with 100 width lines.

@JoeGruffins
Copy link
Author

Code updates suggested by @itswisdomagain https://github.com/cake-tech/cake_wallet/compare/a7266c24a573429b5d4df1c3f216e0dfcc4e5367..1fb22ab832d390db176ad5b1db02e7c6785c0031

I can't figure out how to get the address you tap on in the list to become the one the screen is showing.

@JoeGruffins
Copy link
Author

JoeGruffins commented Jan 13, 2025

I think maybe we don't want to add ourselves to isBIP39Wallet so we can stay a "single seed wallet" which solves the encoded date problem for now.

Also the file assets/decred_node_list.yml didn't have any useful info in it and we don't need the nodelist so removed.

https://github.com/cake-tech/cake_wallet/compare/1fb22ab832d390db176ad5b1db02e7c6785c0031..7162c3360e85e40a260c451efd8c73f4550d52cb#diff-262df68f3a9ec8abd2f1cf18d9b526dfe38f817cfc5dcc1abfb113575752d8a7

@JoeGruffins
Copy link
Author

Now populating transaction history before sync.

@JoeGruffins
Copy link
Author

decred: Fix send all updates the libwallet and allows for sending all inputs. The bug that may stall sync is also fixed with the dependency update.

@JoeGruffins JoeGruffins force-pushed the updateaddresses branch 2 times, most recently from 3b13bdb to 1b31198 Compare January 19, 2025 00:27
@JoeGruffins
Copy link
Author

In my local commit history I have a

commit db067929d03ad139e94b2df30494f7c133d19172
Author: Czarek Nakamoto <[email protected]>
Date:   Thu Jan 16 11:34:43 2025 +0100

    [skip slack] [run tests] clone by sha

But for some reason I do not see it here. My last commit hash is the same though.

@JoeGruffins
Copy link
Author

I updated the logo colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants