CW-832-cupcake-post-release-things #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MrCyjaneK
commented
Nov 22, 2024
MrCyjaneK
commented
- Random name generator button
- Not entering a wallet name error (should be enhanced)
- on restore wallet top screen it says "create wallet" instead of restore wallet
- Not entering a wallet name error (should be more friendly and preferably on the field not a popup)
- When renaming a wallet to the same name, we need to improve the error message
- titles for pin screen
- tap to copy (verify - add a toast)
- biometric auth
- create pin screen - once there is a pin make only one pin, without confirmation
- Random name generator button - Not entering a wallet name error (should be enhanced) - on restore wallet top screen it says "create wallet" instead of restore wallet - Not entering a wallet name error (should be more friendly and preferably on the field not a popup) - When renaming a wallet to the same name, we need to improve the error message - titles for pin screen - tap to copy (verify - add a toast) - biometric auth - create pin screen - once there is a pin make only one pin, without confirmation
OmarHatem28
reviewed
Nov 26, 2024
OmarHatem28
approved these changes
Nov 26, 2024
lib/widgets/form_builder.dart
Outdated
| @@ -29,6 +37,13 @@ class _FormBuilderState extends State<FormBuilder> { | |||
| setState(() {}); | |||
| } | |||
|
|
|||
| String? lastSuggestedTitle = DateTime.now().toIso8601String(); | |||
| void onLabelChange(String? suggestedTitle) { | |||
There was a problem hiding this comment.
having same name is confusing, I know the other one would need widget. but still should at least be private then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.