Fix phpstan errors and update baseline

cakephp · Jan 2, 2024 · 8ff419f · 8ff419f
1 parent a75e138
commit 8ff419f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -35,6 +35,11 @@ parameters:
 			count: 1
 			path: src/Db/Adapter/PdoAdapter.php
 
+		-
+			message: "#^Offset 'id' on array\\<string, mixed\\> in isset\\(\\) always exists and is not nullable\\.$#"
+			count: 2
+			path: src/Db/Adapter/PostgresAdapter.php
+
 		-
 			message: "#^Offset 'id' on array\\<string, mixed\\> in isset\\(\\) always exists and is not nullable\\.$#"
 			count: 2

diff --git a/src/Db/Adapter/PostgresAdapter.php b/src/Db/Adapter/PostgresAdapter.php
@@ -220,6 +220,9 @@ public function hasTable(string $tableName): bool
                 $this->getConnection()->quote($parts['table'])
             )
         );
+        if (!$result) {
+            return false;
+        }
 
         return $result->rowCount() === 1;
     }
@@ -1658,7 +1661,8 @@ public function bulkinsert(Table $table, array $rows): void
             $override = self::OVERRIDE_SYSTEM_VALUE . ' ';
         }
 
-        $sql .= '(' . implode(', ', array_map([$this, 'quoteColumnName'], $keys)) . ') ' . $override . 'VALUES ';
+        $callback = fn ($key) => $this->quoteColumnName($key);
+        $sql .= '(' . implode(', ', array_map($callback, $keys)) . ') ' . $override . 'VALUES ';
 
         if ($this->isDryRunEnabled()) {
             $values = array_map(function ($row) {