Start switching to cakephp/database for schema reflection #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start to remove logic we can get from cakephp/database.
cakephp/database uses " for identifier quoting (as per the sqlite docs) but historically phinx used `. Many tests had to changes for this. While we were doing a good job of supporting all the quoting styles in most places a few were missed. I also found a few places we were doing quoting with simple interpolation which isn't ideal. Because cake's quoting supports less exotic table names we don't need to support those in migrations anymore either.
Don't pollute the disk with cache files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start the set of changes to switch migrations adapters to use cakephp/database more for schema reflection. The SQLite adapter required many changes to align on
"for identifier quoting instead of backtick. While backtick works it is listed as a 'non-standard compatibility'.I also found a few places where we weren't using the quoting methods and were relying on simple string interpolation and fixed those as well. I'll continue to convert schema reflection logic for sqlite and other adapters in a series of pull requests to keep changes reasonably sized.