strip spaces from app users

caktus · Feb 11, 2025 · 338e77d · 338e77d
1 parent 8bbc3e0
commit 338e77d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/apps/odk_publish/forms.py b/apps/odk_publish/forms.py
@@ -78,7 +78,7 @@ def __init__(self, request: HttpRequest, form_template: FormTemplate, *args, **k
     def clean_app_users(self):
         """Validate by checking if the entered app users are in this project."""
         if app_users := self.cleaned_data.get("app_users"):
-            app_users_list = app_users.split(",")
+            app_users_list = [name.strip() for name in app_users.split(",")]
             app_users_in_db = self.request.odk_project.app_users.filter(
                 name__in=app_users_list
             ).order_by("name")

diff --git a/tests/odk_publish/test_forms.py b/tests/odk_publish/test_forms.py
@@ -37,3 +37,11 @@ def test_app_users(self, req: HttpRequest):
         data = {"app_users": "user1,user2", "form_template": form_template.id}
         form = PublishTemplateForm(data=data, request=req, form_template=form_template)
         assert form.is_valid(), form.errors
+
+    def test_app_users_with_spaces(self, req: HttpRequest):
+        form_template = FormTemplateFactory(project=req.odk_project)
+        AppUserFactory(project=req.odk_project, name="user1")
+        AppUserFactory(project=req.odk_project, name="user2")
+        data = {"app_users": " user1, user2 ", "form_template": form_template.id}
+        form = PublishTemplateForm(data=data, request=req, form_template=form_template)
+        assert form.is_valid(), form.errors