Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle dry-run for slot reservation #18865

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle dry-run for slot reservation #18865

wants to merge 1 commit into from
+34 −4

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Jan 24, 2025 •
edited
Loading

What does this PR do?

Also fixes invisible page when required param is missing in headless router(i.e. /router)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Jan 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jan 24, 2025 0:53am
calcom-web-canary ⬜️ Ignored (Inspect) Jan 24, 2025 0:53am

@github-actions GitHub Actions
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "More dry run fixes". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Jan 24, 2025
hariombalhara
hariombalhara commented Jan 24, 2025
View reviewed changes
apps/web/pages/router/index.tsx
@@ -4,6 +4,8 @@ import Head from "next/head";

import type { inferSSRProps } from "@calcom/types/inferSSRProps";

import PageWrapper from "@components/PageWrapper";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue of invisible page when /router has missing required fields

hariombalhara
hariombalhara commented Jan 24, 2025
View reviewed changes
headless-routing-to-booking-flow.md
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just documented this, while identify what all could be not handled by dry-run. Could be useful for later as well.

hariombalhara
hariombalhara commented Jan 24, 2025
View reviewed changes
packages/trpc/server/routers/viewer/slots/reserveSlot.handler.ts
@@ -54,7 +54,7 @@ export const reserveSlotHandler = async ({ ctx, input }: ReserveSlotOptions) =>
}
}

if (eventType && shouldReserveSlot) {
if (eventType && shouldReserveSlot && !_isDryRun) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't reserve slots through dry run

@hariombalhara hariombalhara changed the title More dry run fixes fix: handle dry-run for slot reservation Jan 24, 2025
@hariombalhara hariombalhara marked this pull request as ready for review January 24, 2025 12:56
@graphite-app graphite-app bot requested a review from a team January 24, 2025 12:56
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Jan 24, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 24, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/24/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hariombalhara @keithwillcode