Fix multiply defined symbols #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 29, 2020 18:56
The decent way to fix this would be to put Lalibe in its own namespace, in which case lifting code from Chroma does not lead to multipe definitions anymore. This is the quick and dirty fix. I need to take a shower.
|
I would like to see some regression testing before this is merged in, as these changes touch many files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring to avoid clashes through multiply defined symbols, caused by code transplanted from Chroma into Lalibe. Lalibe unfortunately doesn't use a separate namespace, and so transplanted code leads to conflicts through multiply defined symbols.
Code compiles now under gcc 7.4.0.