Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin micromamba version in CI #691

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Pin micromamba version in CI #691

merged 2 commits into from
Sep 30, 2024

Conversation

brynpickering
Copy link
Member

Fixes failing tests seen in #690

This is caused by latest micromamba updating to v2.0 and lots of issues arising. This one seems to have been flagged by someone else here

Summary of changes in this pull request

  • Pin to most recent v1 micromamba

Reviewer checklist

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (683a5b7) to head (dd6fef2).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          26       26           
  Lines        3981     3981           
  Branches      837      768   -69     
=======================================
  Hits         3821     3821           
  Misses         70       70           
  Partials       90       90           

Copy link
Contributor

@irm-codebase irm-codebase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall.
However, I would open an issue to keep track of this, as we most likely want to update mamba sooner rather than later.

@brynpickering brynpickering merged commit 85c61c9 into main Sep 30, 2024
12 checks passed
@brynpickering brynpickering deleted the fix-micromamba-ci-version branch September 30, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants