Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes global regex value #104

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Conversation

coordt
Copy link
Member

@coordt coordt commented Dec 15, 2023

Fixes #64

Changed default regex CLI value to None.

The default value of False was overriding other values.

Fixes #64

The default value of False was overriding other values.
@coordt coordt linked an issue Dec 15, 2023 that may be closed by this pull request
Copy link

Version hint: minor
Current version: 0.14.0
New version (when merged): 0.15.0

Comment ID: Display the version hint-auto-generated

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (909396d) 93.24% compared to head (93191f3) 92.96%.
Report is 3 commits behind head on master.

Files Patch % Lines
bumpversion/files.py 33.33% 1 Missing and 1 partial ⚠️
bumpversion/version_part.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   93.24%   92.96%   -0.29%     
==========================================
  Files          19       19              
  Lines        1243     1250       +7     
  Branches      256      257       +1     
==========================================
+ Hits         1159     1162       +3     
- Misses         56       59       +3     
- Partials       28       29       +1     
Flag Coverage Δ
python-3.10 92.96% <50.00%> (-0.29%) ⬇️
python-3.11 92.96% <50.00%> (-0.29%) ⬇️
python-3.8 92.96% <50.00%> (-0.29%) ⬇️
python-3.9 92.96% <50.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coordt coordt merged commit 4300249 into master Dec 16, 2023
10 of 12 checks passed
@coordt coordt deleted the 64-global-regex-configuration-not-inherited branch December 16, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global regex configuration not inherited in sub-sections
1 participant