switchrpc: protect from attemptID reuse #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinrzachman
force-pushed
the
switchrpc
branch
3 times, most recently
from
ffe811c to
fb84a6c
Compare
Add a memory optimized store for SendOnion/TrackOnion duplication/safe ordering protection. This ensures that if TrackOnion returns PAYMENT_ID_NOT_FOUND or SendOnion initiates HTLC creation for a given attempt ID, SendOnion cannot subsequently succeed with the same attempt ID. This mechanism safeguards against overpayment in scenarios where network requests are reordered. If an attempt ID has already been used by either SendOnion or TrackOnion, SendOnion will return DUPLICATE_HTLC for that attempt ID. Used https://github.com/RoaringBitmap/roaring as a store for attemp IDs.
starius
force-pushed
the
protect-from-attempt-id-reuse
branch
from
49ed723 to
c08ed3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Add a memory optimized store for SendOnion/TrackOnion duplication/safe ordering protection. This ensures that if TrackOnion returns PAYMENT_ID_NOT_FOUND or SendOnion initiates HTLC creation for a given attempt ID, SendOnion cannot subsequently succeed with the same attempt ID. This mechanism safeguards against overpayment in scenarios where network requests are reordered. If an attempt ID has already been used by either SendOnion or TrackOnion, SendOnion will return DUPLICATE_HTLC for that attempt ID.
Used https://github.com/RoaringBitmap/roaring as a store for attemp IDs.