watchtower/client: immediately negotiate session with first candidate tower #3
+73
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for lnd:
|
|
…ed tower Whether or not we have any candidate towers, the session negotiator will begin attempting to negotiate a session. While there are no candidate towers, the negotiator will just churn with exponential backoff. Upon addition of the first tower, we won't establish a usable session until after the exponential backup delay times out. In order to avoid waiting for exponential backoff, we should not begin session negotiation until we have a candidate tower. This way we can immediately negotiate a session with the first newly added tower and promptly get to backing up those payment channel state updates!
calvinrzachman
force-pushed
the
immediate-first-session
branch
from
610ab51 to
23df7e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether or not we have any candidate towers, the client will request its session negotiator begin attempting to negotiate a session. While there are no candidate towers, the negotiator will just churn with exponential backoff. Upon addition of the first tower, we won't establish a usable session until after the exponential backup delay times out. In order to avoid waiting for exponential backoff, we should not begin session negotiation until we have a candidate tower. This way we can immediately negotiate a session with the first newly added tower and promptly get to backing up those payment channel state updates!
While this PR is not strictly necessary for correctness, it may provide a rather small quality of life improvement in the scenario in which a user is adding a first tower. Let me know if this is something others think is worth adding or if the small behavior change is not worth the addition of another similarly structured
select{}statement.Thanks!
See here for alternative way to achieve the same thing, possibly with an easier to read diff, but which does add a somewhat odd method to the
SessionNegotiatorinterface.Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.