Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release r2.1 (Release Candidate) #202

Merged
merged 11 commits into from
Jan 30, 2025
Merged

Conversation

PedroDiez
Copy link
Collaborator

@PedroDiez PedroDiez commented Jan 14, 2025

What type of PR is this?

Add one of the following kinds:

  • correction
  • enhancement/feature
  • documentation
  • subproject management
  • tests

What this PR does / why we need it:

Generation of release r2.1 (release candidate) for Carrier Billing APIs Family

This release contains the definition and documentation of

  • Carrier Billing v0.4.0-rc.1
  • Carrier Billing Refund v0.2.0-rc.1

The API definition(s) are based on

  • Commonalities v0.5.0-alpha.1
  • Identity and Consent Management v0.3.0-alpha.1

Which issue(s) this PR fixes:

Fixes #196
Fixes #197
Fixes #199
Fixes #200

Special notes for reviewers:

Alignments with Commonalities r2.2 in advance in commit 0dddf48

Changelog input

 Carrier Billing Release r2.1

Additional documentation

This section can be blank.

docs

@PedroDiez PedroDiez self-assigned this Jan 14, 2025
@PedroDiez PedroDiez added documentation Improvements or additions to documentation enhancement New feature or request correction API specification needs correction subproject management Actions related to repository/releases labels Jan 14, 2025
@PedroDiez PedroDiez requested a review from rartych January 14, 2025 08:00
@PedroDiez PedroDiez requested a review from a team January 14, 2025 17:36
bigludo7
bigludo7 previously approved these changes Jan 15, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @PedroDiez !

bigludo7
bigludo7 previously approved these changes Jan 27, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work, very few comments from Release Management perspective!

Please have a view on the inconsistent statements regarding the condition for the error response 422 UNNECESSARY_IDENTIFIER.

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PedroDiez for the fixes. Looks good now from Release Management perspective.

@PedroDiez PedroDiez requested review from bigludo7 and hdamker January 29, 2025 16:19
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @PedroDiez for the great work !

@hdamker
Copy link
Contributor

hdamker commented Jan 29, 2025

Don't forget to update your release trackers after creating the pre-release 😄

@PedroDiez PedroDiez merged commit e753a75 into camaraproject:main Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction API specification needs correction documentation Improvements or additions to documentation enhancement New feature or request subproject management Actions related to repository/releases
Projects
None yet
3 participants