-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API-onboarding Document to comply with current API Backlog process and Sandbox / Incubated approach #171
base: main
Are you sure you want to change the base?
Conversation
@jgarciahospital thanks a lot for the PR! I've reviewed the proposed document and will provide my suggestions in two phases:
After step 1 I would approve this PR and we should aim to get it finally reviewed and merged. The changes for step 2 can be done in a new PR, which I volunteer to create. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments for step 1 mentioned in the previous comment. It might make sense to have a call to explain/discuss them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to rename the file to API-Onboarding-and-Lifecycle.md (as already linked within ProjectStructureAndRoles.md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree to do the renaming in a PR immediately afterwards.
documentation/API-onboarding.md
Outdated
|
||
| **Column Name** | **Description** | | ||
|------------------------------------------------|----------------------------------------------------------------------------------------------------------| | ||
| **API [Family] Name** | The name of the API or API family (e.g., "Messaging API Family"). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Family" is ambiguous, it can be understood as the group of APIs within a repository or the group of APIs which are supervised by a Sub Project. I recommend to organize the list on the level of API Repository, not single APIs.
| **API [Family] Name** | The name of the API or API family (e.g., "Messaging API Family"). | | |
| **API Repository Name** | The name of the API or API family (e.g., "Messaging API(s)"). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a bit generic if the list is "APIs", since API proposals are at API level. I'm ok on living it at public release level (easier to track).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See new suggestion to get rid of the "family" term.
Co-authored-by: Herbert Damker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including small adjustments after internal review.
documentation/API-onboarding.md
Outdated
|
||
## TSC decision on API proposal | ||
1. **Repository Creation** | ||
A dedicated repository is created for the API under its assigned Sub-Project or as part of a new Sub-Project. The repository structure shall comply with [CAMARA governance guidelines](https://github.com/camaraproject/Governance/blob/main/ProjectStructureAndRoles.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A dedicated repository is created for the API under its assigned Sub-Project or as part of a new Sub-Project. The repository structure shall comply with [CAMARA governance guidelines](https://github.com/camaraproject/Governance/blob/main/ProjectStructureAndRoles.md). | |
A dedicated Sandbox API Repository is created for the API under its assigned Sub Project or as an independent Sandbox API Repository until incubation phase. The repository structure shall comply with [CAMARA governance guidelines](https://github.com/camaraproject/Governance/blob/main/ProjectStructureAndRoles.md) and will be derived from the [Template_API_Repository](https://github.com/camaraproject/Template_API_Repository). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's seem to be almost the same suggestion then in my comment #171 (comment).
Just the note that as an alternative to incubation there is also the option that an independent Sandbox will be adopted by an existing Sub Project even before incubation. But that's maybe an edge case which we don't need to describe here.
@hdamker thanks for the review. I have included couple of pending changes after internal review, let me review in detail your proposals during next weekend. |
@jgarciahospital short comments on the pending changes. wish you a nice (and/or productive) weekend! |
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
This reverts commit 674a772.
Co-authored-by: Alberto Ramos Monagas <[email protected]>
Co-authored-by: Alberto Ramos Monagas <[email protected]>
Co-authored-by: Alberto Ramos Monagas <[email protected]>
@hdamker Document cleaned and pending for first phase merging. Pending comments/discussions will be handled in second phase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions for changes I would like to see already in this interim version to be more consistent with the other governance documents.
documentation/API-onboarding.md
Outdated
|
||
| **Column Name** | **Description** | | ||
|------------------------------------------------|----------------------------------------------------------------------------------------------------------| | ||
| **API [Family] Name** | The name of the API or API family (e.g., "Messaging API Family"). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See new suggestion to get rid of the "family" term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree to do the renaming in a PR immediately afterwards.
Co-authored-by: Herbert Damker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking all my suggestions. Fine with this interim version, looking forward to the restructuring.
What type of PR is this?
What this PR does / why we need it:
Including modifications for API onboarding document to finalize the inclusion of Sandbox / Incubated way of working.
Pending:
Next steps:
Which issue(s) this PR fixes:
Fixes #173