Correct name of middleNames Match Score attribute in kyc-match yaml file

[GillesInnov35]

Correct name of middleNames Match Score attribute

What type of PR is this?

Add one of the following kinds:

• correction

What this PR does / why we need it:

Correct name of middleNames Match Score response attribute.
Replace middleNamesScore by middleNamesMatchScore

Which issue(s) this PR fixes:

Fixes ##161

Special notes for reviewers:

Changelog input

 release-note

[GillesInnov35]

hi all, this update will break backward compatibility. So could be implemented only in a major version. WDYT
BR
Gilles

[HuubAppelboom]

hi all, this update will break backward compatibility. So could be implemented only in a major version. WDYT BR Gilles

For KPN no problem, we have not gone live yet with customers

[fernandopradocabrillo]

Thanks @GillesInnov35 for the PR. We are actually integrating clients with current version, so let me check the impact with my product team.

[GillesInnov35]

thanks @fernandopradocabrillo, yes there's an impact for current implementation using this attribute. It is not the case at Orange France but it could for others countries. So let's see impact to decide then if we delay this evolution to a major version I think.
BR
Gilles

[GillesInnov35]

hi @ALL, do you think we'll correct this mistake in a future version? Thanks
Gilles

[HuubAppelboom]

hi @ALL, do you think we'll correct this mistake in a future version? Thanks Gilles

Sooner or later this will need to be fixed.

For KPN it is no issue to fix it now, we have not gone live yet with customers.

[ToshiWakayama-KDDI]

hi @ALL, do you think we'll correct this mistake in a future version? Thanks Gilles

Agree that sooner or later this will need to be fixed.

For KDDI, it is no issue to fix it now, since we have not implemented the Scoring function yet.

Thanks,
Toshi

[hdamker]

So let's see impact to decide then if we delay this evolution to a major version I think.

@GillesInnov35 @fernandopradocabrillo please consider that you are still in the phase of initial versions with 0.x. That means that there is no assumption of backward compatibility between 0.x and 0.x+1 (cf. https://semver.org/#spec-item-4). That's the reason that we are distinct the versions for 0.x also within the server url with .../v0.x

Therefore I would say that now is good point in time to introduce such fixes.

[fernandopradocabrillo]

Hi all, yeah, let's fix it, we don't have impact either

[fernandopradocabrillo]

LGTM

[GillesInnov35]

hi @ToshiWakayama-KDDI , could you approve the PR if OK for you of course.
Thanks a lot
BR
Gilles

[ToshiWakayama-KDDI]

Thanks a lot. Sorry for the delay.

[GillesInnov35]

Thanks a lot @ToshiWakayama-KDDI