Staff Payment Validation Update (bcgov#1830)

* Update Staff Payment validation for Priority checkbox
cameron-eyds · Apr 16, 2024 · aa6e57b · aa6e57b
1 parent 6a3dfcc
commit aa6e57b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/ppr-ui/package-lock.json b/ppr-ui/package-lock.json
diff --git a/ppr-ui/package.json b/ppr-ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ppr-ui",
-  "version": "3.0.85",
+  "version": "3.0.86",
   "private": true,
   "appName": "Assets UI",
   "sbcName": "SBC Common Components",

diff --git a/ppr-ui/src/components/common/StaffPayment.vue b/ppr-ui/src/components/common/StaffPayment.vue
@@ -229,6 +229,13 @@ export default defineComponent({
       validatePaymentType()
     })
 
+    /** Trigger validation separately for Priority checkbox because after Staff Payment data update */
+    watch(() => localState.staffPaymentData.isPriority, async () => {
+      await nextTick()
+      validatePaymentType()
+      context.emit('valid', localState.isValid)
+    })
+
     /** Watches for changes to Staff Payment Data Validation flag. */
     watch(() => localState.isValid, async (isValid: boolean): Promise<void> => {
       context.emit('valid', isValid)

diff --git a/ppr-ui/src/views/newMhrRegistration/MhrReviewConfirm.vue b/ppr-ui/src/views/newMhrRegistration/MhrReviewConfirm.vue
@@ -239,7 +239,7 @@ export default defineComponent({
           !getValidation(MhrSectVal.REVIEW_CONFIRM_VALID, MhrCompVal.AUTHORIZATION_VALID)
       }),
       validateStaffPayment: computed(() => {
-        return isRoleStaffReg && localState.isValidatingApp &&
+        return isRoleStaffReg.value && localState.isValidatingApp &&
           !getValidation(MhrSectVal.REVIEW_CONFIRM_VALID, MhrCompVal.STAFF_PAYMENT_VALID)
       }),
       hasStaffPaymentValues: computed(() => {