fix: Report correct guest UUID, when VM Generation 2 is used #421
+77
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirihnidek
force-pushed
the
jhnidek/ctc-676
branch
from
934fa7b to
a91bd0a
Compare
* Card ID: CCT-676
* When VM is created as Generation 2 in the setup wizard of
Hyper-V hypervisor, then hypervisor reports UUID of given
VM using little-endian. Thus it is not necessary to
convert this UUID as we do for Generation 1.
* We solve this issue by extending SQL query. We also ask
for VirtualSystemSubType, which contains version of VM
generation ("Microsoft:Hyper-V:SubType:1" or
"Microsoft:Hyper-V:SubType:2"). When VM is generation 1,
then we convert UUID from big-endian to little-endian
as we have did it in the past. When generation is 2 and
major version of Hyper-V vmms is greater than 10, then
we do nothing with guest UUID.
* Changed code around little bit, because there was variable
uuid used for different purpose and it was confusing.
* TODO: hyperv.py deserves more refactoring
* More information about generation 1 or 2 on Hyper-V could be
found e.g. here:
* https://learn.microsoft.com/en-us/windows-server/virtualization/hyper-v/get-started/create-a-virtual-machine-in-hyper-v
* https://learn.microsoft.com/en-us/windows-server/virtualization/hyper-v/plan/should-i-create-a-generation-1-or-2-virtual-machine-in-hyper-v
jirihnidek
force-pushed
the
jhnidek/ctc-676
branch
from
a91bd0a to
93ae61a
Compare
jirihnidek
commented
Feb 10, 2025
| if gen_version is None or gen_version == self.GEN_VERSION_1: | ||
| return s[6:8] + s[4:6] + s[2:4] + s[0:2] + "-" + s[11:13] + s[9:11] + "-" + s[16:18] + s[14:16] + s[18:] | ||
| elif gen_version == self.GEN_VERSION_2: | ||
| if vmms_major_ver <= 10: |
There was a problem hiding this comment.
We need to know the right value of this threshold. The value 10 is only estimation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Microsoft:Hyper-V:SubType:1"or"Microsoft:Hyper-V:SubType:2"). When VM is generation 1, then we convert UUID from big-endian to little-endian as we have did it in the past. When generation is 2, then we do nothing with guest UUID.uuidused for different purpose and it was confusing.hyperv.pydeserves more refactoring