Skip to content

Commit

Permalink
build: fix build error.
Browse files Browse the repository at this point in the history
  • Loading branch information
cangzhang committed Jun 11, 2022
1 parent 282757b commit 55e017c
Show file tree
Hide file tree
Showing 5 changed files with 21,780 additions and 13,107 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
shell: pwsh
run: |
$sha = (git rev-parse --short HEAD)
npm install
npm ci
$env:SHORT_SHA=$sha; npm run release
- name: Move artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ jobs:

- name: Build
run: |
npm ci
$sha = (git rev-parse --short HEAD)
npm install
$env:SHORT_SHA=$sha; npm run build:ci
$env:BUILD_IN_CI=true; $env:SHORT_SHA=$sha; npm run build:ci
- name: Move artifacts
id: vars
Expand Down
4 changes: 2 additions & 2 deletions config/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const ForkTsCheckerWebpackPlugin = require('react-dev-utils/ForkTsCheckerWebpack
const typescriptFormatter = require('react-dev-utils/typescriptFormatter');
const CompressionPlugin = require('compression-webpack-plugin');
const ImageminWebpWebpackPlugin = require('imagemin-webp-webpack-plugin');
const ReactRefreshWebpackPlugin = require('@pmmmwh/react-refresh-webpack-plugin');
// const ReactRefreshWebpackPlugin = require('@pmmmwh/react-refresh-webpack-plugin');

const ReplaceCssUrlExtPlugin = require('./plugins/replace-css-url-ext');
const appPackageJson = require(paths.appPackageJson);
Expand Down Expand Up @@ -550,7 +550,7 @@ module.exports = function (webpackEnv) {
// This is necessary to emit hot updates (currently CSS only):
isEnvDevelopment && new webpack.HotModuleReplacementPlugin(),

isEnvDevelopment && new ReactRefreshWebpackPlugin(),
// isEnvDevelopment && new ReactRefreshWebpackPlugin(),

// Watcher doesn't work well if you mistype casing in a path so we use
// a plugin that prints an error when you attempt to do this.
Expand Down
Loading

0 comments on commit 55e017c

Please sign in to comment.