Merge pull request #168 from canjs/observable-built-ins

making it possible to serialize observable built-ins
canjs · Aug 27, 2019 · f6096d6 · f6096d6
2 parents c59a289 + 88c4f3d
commit f6096d6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/reflections/shape/shape-test.js b/reflections/shape/shape-test.js
@@ -711,6 +711,18 @@ QUnit.test("assignDeepList", function(assert) {
 	], "assigned right");
 });
 
+QUnit.test(".serialize works for observable built ins", function(assert) {
+	var obj = document.createElement("div");
+	obj[canSymbol.for("can.serialize")] = function() {
+		return "serialized value";
+	};
+
+	// mark object as observable
+	obj[canSymbol.for("can.onKeyValue")] = function() {};
+
+	assert.deepEqual(shapeReflections.serialize(obj), "serialized value");
+});
+
 
 /*QUnit.test("getAllEnumerableKeys", function(){
 

diff --git a/reflections/shape/shape.js b/reflections/shape/shape.js
@@ -105,7 +105,7 @@ function isSerializedHelper(obj){
 	if(hasUpdateSymbol(obj)) {
 		return false;
 	}
-	return typeReflections.isBuiltIn(obj) && !typeReflections.isPlainObject(obj) && !Array.isArray(obj);
+	return typeReflections.isBuiltIn(obj) && !typeReflections.isPlainObject(obj) && !Array.isArray(obj) && !typeReflections.isObservableLike(obj);
 }
 
 // IE11 doesn't support primitives