Skip to content

Commit

Permalink
chore: fix rocks terminology
Browse files Browse the repository at this point in the history
  • Loading branch information
cjdcordeiro committed May 23, 2024
1 parent 93529f1 commit 42bc4fd
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 12 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build ROCK
name: Build rock

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down Expand Up @@ -34,7 +34,7 @@ jobs:
run: |
sudo snap install yq
sudo snap install rockcraft --classic --edge
- name: Build ROCK
- name: Build rock
run: |
app_version=$(yq '.version' rockcraft.yaml)
version=$(yq '(.version|split("-"))[0]' rockcraft.yaml)
Expand All @@ -45,7 +45,7 @@ jobs:
sed -i "0,/${app_version}/{s//${tag}/}" rockcraft.yaml
rockcraft pack --verbose
- name: Upload locally built ROCK artifact
- name: Upload locally built rock artifact
uses: actions/upload-artifact@v3
with:
name: charmed-superset-rock
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Publish ROCK
name: Publish rock
on:
push:
branches:
Expand Down
17 changes: 10 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
# Charmed Apache Superset ROCK
# Charmed Apache Superset rock

This repository contains the packaging metadata for creating a Charmed Superset ROCK. This ROCK image is based on the upstream [Apache Superset](https://downloads.apache.org/superset/) image.
This repository contains the packaging metadata for creating a Charmed Superset rock. This rock is based on the upstream [Apache Superset](https://downloads.apache.org/superset/) image.

For more information on ROCKs, visit the [rockcraft Github](https://github.com/canonical/rockcraft).
For more information on rocks, visit the [rockcraft Github](https://github.com/canonical/rockcraft).

## Building the ROCK
The steps outlined below are based on the assumption that you are building the ROCK with the latest LTS of Ubuntu.
## Building the rock

The steps outlined below are based on the assumption that you are building the rock with the latest LTS of Ubuntu.
If you are using another version of Ubuntu or another operating system, the process may be different.
To avoid any issue with other operating systems you can simply build the image with [multipass](https://multipass.run/):
```bash
Expand Down Expand Up @@ -35,7 +36,9 @@ newgrp docker
sudo snap disable docker
sudo snap enable docker
```
### Packing and Running the ROCK

### Packing and Running the rock

```bash
rockcraft pack
sudo skopeo --insecure-policy copy oci-archive:charmed-superset-rock_2.1.0-22.04-edge_amd64.rock docker-daemon:charmed-superset-rock:2.1.0
Expand All @@ -61,7 +64,7 @@ Further information on connecting data sources and creating dashboards can be fo
`make clean-all` will remove the image and get you ready to start from `make dev`

## License
The Charmed Superset ROCK is free software, distributed under the Apache
The Charmed Superset rock is free software, distributed under the Apache
Software License, version 2.0. See
[LICENSE](https://github.com/canonical/charmed-superset-rock/blob/main/LICENSE)
for more information.
2 changes: 1 addition & 1 deletion rockcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
name: charmed-superset-rock
base: [email protected]
version: 2.1.0-22.04-edge
summary: Charmed Superset ROCK OCI
summary: Charmed Superset rock OCI
description: |
Superset is a business intelligence tool that is fast, lightweight,
intuitive, and loaded with options that make it easy for users
Expand Down

0 comments on commit 42bc4fd

Please sign in to comment.