Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove talisker #273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Nov 28, 2023

Done

  • Replace Talisker with FlaskBase requests

QA

  • Modify requirements.txt by commenting out canonicalwebteam.flask-base==1.1.0 and replacing it with
git+https://github.com/britneywwc/canonicalwebteam.flask-base.git@request-logs#egg=canonicalwebteam.flask-base
  • Run the webapp with dotrun

Issue / Card

Fixes WD-7618

@webteam-app
Copy link

Demo starting at https://dqlite-io-273.demos.haus

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4cacfd1) 75.60% compared to head (1b38fd9) 75.60%.
Report is 3 commits behind head on main.

❗ Current head 1b38fd9 differs from pull request most recent head 9c1148f. Consider uploading reports for the commit 9c1148f to get more accurate results

Files Patch % Lines
webapp/app.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   75.60%   75.60%           
=======================================
  Files           3        3           
  Lines          41       41           
=======================================
  Hits           31       31           
  Misses         10       10           
Flag Coverage Δ
python 75.60% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants