-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the status on different exceptions that are raised #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2ca4a1
to
b465b91
Compare
mvlassis
reviewed
Feb 12, 2025
mvlassis
reviewed
Feb 12, 2025
mvlassis
reviewed
Feb 12, 2025
Co-authored-by: Manos Vlassis <[email protected]>
Co-authored-by: Manos Vlassis <[email protected]>
mvlassis
reviewed
Feb 12, 2025
mvlassis
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, nice work!
Co-authored-by: Manos Vlassis <[email protected]>
mvlassis
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
Right now the Charm will go in a blocked status, but a lot of times it won't have a helpful error message. This PR improves the error handling to also set a status, but not when an action is triggered.
Changes
_sync_profiles()
to set the status of the charm_sync_profiles()
to raiseErrorWithStatus
on API errorsReview Notes
Here's a following sequence of commands I tried and the corresponding charm statuses. In all cases shown the charm was in Blocked state.