Feat/operator workflow integration test #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 82 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 36 | 1 | 45 | 0 |
Click to see the invalid file list
- scripts/pre-integration-test.sh
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Remove catching of base exception * Change random string generation method * Add integration test of reconcile_interval * Add reconcile interval test * Update interval config * Add test for update-interval * Fix merge issues * Update the status during checking of update * Fix usage of wrong fixture * Fix reconcile_interval and update_interval for juju 3.x * Run apt-get clean on runner setup * Add juju 3.x support * Add juju 2.9 integration tests * Fix workflow * Fix juju 2.9 integration test * Fix test * Add module for tests of scheduled events * Split deployment and spawning of runner in test fixture * Debugging juju 2.9 integration tests * Fix juju 3 and juju 2 support * Update reconcile-interval test * Fix support for juju 2 integration test * Fix support for juju 2 integration test * Fix waiting for juju 2 integration test * Fix action wait * Fix juju 2 support * Fix missing key from no stdout returned * Fix typo during refactor * Fix type problem due to juju 2 and juju 3 difference * Fix type issues * Fix conflict between juju 2 and juju 3 test running in parallel on github * Debug workflow * Debug github action * Restrict concurrency of GitHub workflow for integration tests * Fix typo * Fix juju app name * Update documentation * Rename assert_num_runners * Add tox param for juju version * Use matrix job for integration tests * Fix formatting * Fix support for juju 2 and juju 3 tox * Enable running integration tests in parallel * Add integration test for reconcile interval and update interval config (#97) * Remove catching of base exception * Add integration test of reconcile_interval and update_interval * Run apt-get clean on runner setup * Add juju 3.x support * Add juju 2.9 integration tests * Update jitter to random_delay --------- Co-authored-by: Yanks Yoon <[email protected]> * Configure Renovate (#24) * Add renovate.json * Do not require license for json files --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: arturo-seijas <[email protected]> Co-authored-by: arturo-seijas <[email protected]> * Resolve conflicts * Allow integration test to be ran in parallel * Test confined LXD container with microk8s * Revert to unconfined mode for apparmor during e2e testing * Add test for network access * Add waiting for HTTP server to start up * Load HTTP service via bash * Fix github api changes * Remove unneed file * Fix command string * Fix typing issue * Check for return code of curl --------- Co-authored-by: Yanks Yoon <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: arturo-seijas <[email protected]> Co-authored-by: arturo-seijas <[email protected]>
* Remove LXD profile prior to retrying creating LXD instance * Add missing docstring * Add unit test * Fix test * Fix integration test * Move integration test to test_charm.py * Add retry for deletion of LXD profile * debug * Debug * Fix removal of storage profile * Fix bug * Fix bug due to github api change * Remove debug
* Add public interface * Remove promtail prefix from fcts * Fix license header * Merge install and config into start * Add interface to log metrics * Add grafana_dashboard lib * Move logging of event to metrics module * Introduce charm state * Update attrs doc * Implement COS integration * Remove grafana_dashboard * Change proxy server settings in test_charm * Ignore whitelist in pylintrc * Add missing newlines * Exclude woke.yaml from license check * Add final newline to .woke.yaml * Remove usage of requests.session in metrics * Pin pydantic more specifically * Fix type hint/doc string in ProxyConfig * Pin pydantic * Rename NotCompleteError * Remove hardcoding of promtail arch * Remove hardcoding of promtail arch * Rename -> download_info * promtail.start -> promtail.setup * handle non-happy case first in metrics * Remove group * Adapt promtail.yaml.j2 * Introduce constant in test_charm * Move issue_metrics to RunnerManagerConfig * Fix promtail.service.j2 * Capture time only when needed * Narrow the exception catch * Introduce constants in Promtail * Retry Promtail health check and raise error * Use Path.write_bytes in promtail * set unit status to Blocked for unhealthy promtail * Fix integration test Breaking change in latest Pygithub version * Lint * Catch RequestException * Drop Promtail and call Loki directly * Add unit test for charm state * Switch to cos_agent integration * Adapt integration test * Fix integration test * Simplify integration test * Fix issue_event * Add code to set up logrotate * Update grafana dashboard * Cleanup * Remove status in wait_for_idle * Small fixes * Dont keep charm inside state * Update src-docs * Dont use mutable default value * Compute event name on instantiation * Raise LogrotateSetupError * Reuse _create_runner func * Check that metrics log is empty * Fix docstring in Event * Lint * app_no_runner -> app
|
Test coverage for 7c3e140 Static code analysis report |
Thanhphan1147
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Convert to using operator workflow for integration tests
Rationale
Standardize the integration tests runs across charms repos.
Checklist
src-docsurgent,trivial,complex)