Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align OpenStack runner with local LXD runners and fix reconcile #268

Merged
merged 9 commits into from
Apr 24, 2024
Merged

Align OpenStack runner with local LXD runners and fix reconcile #268

merged 9 commits into from
Apr 24, 2024

Conversation

yhaliaw
Copy link
Collaborator

@yhaliaw yhaliaw commented Apr 24, 2024 •
edited
Loading

Overview

  • Docker should use our dockerhub mirror by default.
  • LXD/LXC commands can be executed without sudo.
  • Fix reconcile for OpenStack runners to spawn more than one runners.

Test result:
https://github.com/canonical/github-runner-operator/actions/runs/8812133448

Rationale

Align OpenStack runners with local LXD runners.
Bug fix for reconcile of OpenStack runners.

Checklist

cbartz
cbartz previously approved these changes Apr 24, 2024
View reviewed changes
@cbartz cbartz dismissed their stale review April 24, 2024 06:18

Overlooked a line

@yhaliaw yhaliaw marked this pull request as ready for review April 24, 2024 06:59
@yhaliaw yhaliaw requested a review from a team as a code owner April 24, 2024 06:59
@yhaliaw yhaliaw merged commit a80cb2c into feat/openstack-integration Apr 24, 2024
3 of 9 checks passed
@yhaliaw yhaliaw deleted the feat/openstack-cloud-init branch April 24, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbartz cbartz cbartz approved these changes

Assignees
No one assigned
Labels
trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhaliaw @cbartz