Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Feat/private endpoint #284

Merged
merged 151 commits into from
Jun 26, 2024
Merged

Conversation

yanksyoon
Copy link
Collaborator

Applicable spec:

Overview

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

cbartz added 30 commits April 25, 2024 17:29
ValidationError inherits from ValueError
…ack-repo-policy-ISD-1825

# Conflicts:
#	src/openstack_cloud/openstack_manager.py
Copy link
Contributor

Test coverage for a83c42d

Name                                       Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------------------
src/charm.py                                 518    135    127     28    71%   115-116, 118-119, 124-125, 211-213, 266-285, 303-305, 306->310, 336-340, 359-374, 451-462, 469-471, 498-503, 520-523, 544, 556-562, 576-577, 590, 595, 624-625, 627->636, 631->636, 640-644, 679, 683-688, 725-728, 737->740, 763-780, 784-785, 813-837, 850-853, 874-883, 897-899, 946-947, 949-950, 952-953, 1032->1034, 1099-1100, 1138-1140, 1148-1152, 1165
src/charm_state.py                           412     15     88      3    95%   325-337, 519-523, 607-608, 666-667, 1079
src/errors.py                                 42      0      0      0   100%
src/event_timer.py                            54      7      2      1    86%   105-106, 131, 148-149, 165-166
src/firewall.py                               51     18     20      0    61%   42-43, 66-69, 111-185
src/github_client.py                          96     16     40      5    79%   65-72, 119->exit, 124-125, 195, 218, 231-238, 260->300, 294
src/github_type.py                            50      0      0      0   100%
src/lxd_type.py                               35      0      2      0   100%
src/metrics/__init__.py                        0      0      0      0   100%
src/metrics/events.py                         75      2     10      1    96%   62->65, 172-173
src/metrics/github.py                         16      0      0      0   100%
src/metrics/runner.py                        143      9     30      2    92%   155, 181-194, 230, 442-443
src/metrics/runner_logs.py                    24      5      4      1    79%   30-33, 47->46, 51-52
src/metrics/storage.py                        70      8     12      0    90%   89-90, 117-118, 182-183, 189-190
src/metrics/type.py                            5      0      0      0   100%
src/openstack_cloud/__init__.py               52     21      6      0    57%   26-43, 51-65
src/openstack_cloud/openstack_manager.py     604    126    186     24    78%   108, 303-304, 490, 544, 546, 548, 646-649, 695, 698, 740-741, 904-931, 991-992, 1058-1059, 1081->exit, 1091, 1118-1119, 1122-1123, 1166, 1175-1176, 1206, 1211-1218, 1231-1237, 1241-1243, 1259-1265, 1284-1285, 1287-1298, 1305-1309, 1313-1316, 1339-1340, 1345-1351, 1369, 1384-1409, 1434-1448, 1464-1471, 1505, 1557-1561, 1631-1636, 1657-1659, 1687-1692, 1714-1715, 1723-1733
src/runner_manager_type.py                    48      0      8      0   100%
src/runner_type.py                            37      0     10      0   100%
src/shared_fs.py                              93     17     10      1    83%   51-52, 119-120, 145-146, 154-155, 161-162, 180, 183-184, 196-197, 240-241
src/utilities.py                              67      7     20      7    82%   85->87, 89->95, 102, 132, 146, 185-188, 243
--------------------------------------------------------------------------------------
TOTAL                                       2492    386    575     73    83%

Static code analysis report

Run started:2024-06-26 11:15:38.347872

Test results:
>> Issue: [B101:assert_used] Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
 Severity: Low   Confidence: High
 CWE: CWE-703 (https://cwe.mitre.org/data/definitions/703.html)
 More Info: https://bandit.readthedocs.io/en/1.7.9/plugins/b101_assert_used.html
 Location: /home/runner/work/github-runner-operator/github-runner-operator/src/metrics/runner.py:263:4
262	    """
263	    assert runner_metrics.post_job
264	    # When a job gets cancelled directly after spawning,

--------------------------------------------------

Code scanned:
  Total lines of code: 7387
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 7

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 1
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 1
Files skipped (0):

@yhaliaw yhaliaw merged commit cb9c34b into feat/openstack-integration Jun 26, 2024
49 of 63 checks passed
@yhaliaw yhaliaw deleted the feat/private-endpoint branch June 26, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants