feat: passive runner deletion #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanksyoon
commented
Jun 12, 2024
| Returns: | ||
| An SSH connection to OpenStack server instance. | ||
| """ | ||
| server: Server | None = conn.get_server(name_or_id=server_name) |
There was a problem hiding this comment.
Refresh server on error (e.g. network not yet attached)
| @staticmethod | ||
| def _get_key_path(name: str) -> Path: | ||
| """Get the filepath for storing private SSH of a runner. | ||
| def reconcile(self, quantity: int) -> int: |
There was a problem hiding this comment.
Step down ordering of methods.
This reverts commit 9b4678e.
yanksyoon
commented
Jun 14, 2024
| ] | ||
|
|
||
| @staticmethod | ||
| def _health_check(conn: OpenstackConnection, server_name: str, startup: bool = False) -> bool: |
yanksyoon
commented
Jun 14, 2024
|
|
||
| @staticmethod | ||
| def _ssh_health_check(server: Server) -> bool: | ||
| def _ssh_health_check(conn: OpenstackConnection, server_name: str, startup: bool) -> bool: |
yanksyoon
commented
Jun 14, 2024
|
|
||
| @staticmethod | ||
| @retry(tries=3, delay=5, max_delay=60, backoff=2, local_logger=logger) | ||
| def _get_ssh_connection( |
There was a problem hiding this comment.
Improved _get_ssh_connection function
yanksyoon
commented
Jun 14, 2024
cbartz
reviewed
Jun 14, 2024
cbartz
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec: N/A
Rejected:
Overview
_get_ssh_connectionfunction to return a single working SSH connection instance. (There is no need to loop over every possible network connections and try them for each business logic)._health_checkfunction that encapsulates the business logic of health checking for both startup and running health checks.Log and alert when there is an unexpected health check result to allow more insights into the state of Openstack GitHub runners.Rationale
To gain more insights into interactions with Openstack.
Juju Events Changes
None.
Module Changes
openstack_manager.py_health_checkfunction_get_ssh_connectionfunctionLibrary Changes
None.
Checklist
src-docsurgent,trivial,complex)Testing has been one on PS6
