Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert updateStrategy of secrets to InPlace #395

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: revert updateStrategy of secrets to InPlace #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion charms/kfp-profile-controller/src/templates/crd_manifests.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Source manifests/apps/pipeline/upstream/base/installs/multi-user/pipelines-profile-controller/composite-controller.yaml
# Change resyncPeriodSeconds to 1 hour from insane 20 seconds
# Change updateStrategy of secrets to InPlace to update on changing minio secret
# Only sync namespaces with pipelines.kubeflow.org/enabled = "true"
apiVersion: metacontroller.k8s.io/v1alpha1
kind: DecoratorController
Expand All @@ -10,7 +11,8 @@ spec:
- apiVersion: v1
resource: secrets
updateStrategy:
method: OnDelete
# updateStrategy is set to InPlace, unlike OnDelete in upstream, to update on changing minio secret
method: InPlace
- apiVersion: v1
resource: configmaps
updateStrategy:
Expand Down