Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: refactor using data platform workflows (#665) #669

Merged
merged 1 commit into from
Feb 4, 2025
Merged

ci: refactor using data platform workflows (#665) #669

merged 1 commit into from
Feb 4, 2025

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Feb 4, 2025

  1. Refactors the charmcraft.yaml files to use st124 shorthand notation and python plugin instead of charm plugin for compatibility with charmcraftcache
  2. Replaces the integrate.yaml and on_pull_request.yaml workflows into ci.yaml, a workflow that does the following:
  • Gets the paths for the charms in the multi-charm repo
  • Builds each charm in a separate runner with charmcraftcache
  • Passes the built charm artifacts to test jobs
  • Runs the individual integration tests for each charm
  • Runs the bundle integration tests
  • Publishes the built charms to <track>/edge/pr-xx channel
  1. Similarly, replaces on_push.yaml with release.yaml workflow, which:
  • Re-uses ci.yaml to run the builds, checks, and tests
  • Published the built charms to <track>/edge only if the tests pass
  1. Renames the old release.yaml to promote.yaml
  2. Refactors the integration test .py files to deploy from the pre-built charms, and keeps the option for local builds ---------

@NohaIhab @DnPlas
@orfeas-k @carlcsaposs-canonical
ci: refactor using data platform workflows (#665)
e8f4487 
1. Refactors the `charmcraft.yaml` files to use `st124` shorthand notation and `python` plugin instead of `charm` plugin for [compatibility](https://github.com/canonical/charmcraftcache?tab=readme-ov-file#step-1-update-charmcraftyaml-to-supported-syntax) with `charmcraftcache`
2. Replaces the integrate.yaml and on_pull_request.yaml workflows into ci.yaml, a workflow that does the following:
  * Gets the paths for the charms in the multi-charm repo
  * Builds each charm in a separate runner with `charmcraftcache`
  * Passes the built charm artifacts to test jobs
  * Runs the individual integration tests for each charm
  * Runs the bundle integration tests
  * Publishes the built charms to `<track>/edge/pr-xx` channel

3. Similarly, replaces on_push.yaml with release.yaml workflow, which:
  * Re-uses ci.yaml to run the builds, checks, and tests
  * Published the built charms to `<track>/edge` only if the tests pass

4. Renames the old `release.yaml` to `promote.yaml`
5. Refactors the integration test .py files to deploy from the pre-built charms, and keeps the option for local builds
---------

Co-authored-by: Daniela Plascencia <[email protected]>
Co-authored-by: Orfeas Kourkakis <[email protected]>
Co-authored-by: Carl Csaposs <[email protected]>
mvlassis
mvlassis approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem OK to me, just make sure to declare in the title that is a backport, and maybe link to the relevant PR

@orfeas-k orfeas-k merged commit 08687ec into track/2.3 Feb 4, 2025
84 of 91 checks passed
@orfeas-k orfeas-k deleted the kf-6880-backport-ci branch February 4, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvlassis mvlassis mvlassis approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orfeas-k @mvlassis @NohaIhab