Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rbac proxy layer #289

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Remove rbac proxy layer #289

merged 4 commits into from
Jan 17, 2025
+3 −114

Conversation

misohu
Copy link
Member

@misohu misohu commented Jan 13, 2025

Closes: #287

This PR removes the rbac proxy layer from the charm. This is possible as kubeflow-rbac-proxy was not intercepting the traffic.

@misohu misohu marked this pull request as ready for review January 16, 2025 13:10
@misohu misohu mentioned this pull request Jan 16, 2025
Closed
@kimwnasptd
Copy link
Contributor

@misohu I did a grep -ri rbac- and found that we still have some references of kube-rbac-proxy in:

  • the README.md
  • the CONTRIBUTING.md

Could you do a pass and clean those as well? Rest LGTM

@misohu misohu merged commit d683def into main Jan 17, 2025
10 checks passed
@misohu misohu deleted the KF-6723-remove-rbac-proxy branch January 17, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@kimwnasptd kimwnasptd kimwnasptd approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚠️ Action Required: Replace Deprecated gcr.io/kubebuilder/kube-rbac-proxy
3 participants
@misohu @kimwnasptd @camilamacedo86