Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First Loki worker implementation #2

Merged
merged 15 commits into from
Jun 24, 2024
Merged

First Loki worker implementation #2

merged 15 commits into from
Jun 24, 2024

Conversation

Abuelodelanada
Copy link
Contributor

@Abuelodelanada Abuelodelanada commented Jun 10, 2024

This is the first implementation of Loki worker charm for the HA deployment.

It's not really functional yet, since we need to finish the Loki coordinator charm.

How to test it

  1. Pack the charm: charmcraft pack
  2. Deploy the charm: juju deploy ./*.charm loki-worker --resource loki-image=docker.io/ubuntu/loki:3.0-22.04 --trust --config all=True
  3. Check the charm is in blocked state with the message: Missing loki-cluster relation to a loki-coordinator charm

@Abuelodelanada Abuelodelanada marked this pull request as ready for review June 14, 2024 14:43
@Abuelodelanada Abuelodelanada requested a review from a team as a code owner June 14, 2024 14:43
README.md Outdated Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
charmcraft.yaml Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/loki_cluster.py Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
@Abuelodelanada Abuelodelanada requested a review from sed-i June 18, 2024 12:20
src/charm.py Outdated Show resolved Hide resolved
src/loki_cluster.py Outdated Show resolved Hide resolved
src/loki_cluster.py Outdated Show resolved Hide resolved
src/loki_cluster.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/loki_cluster.py Show resolved Hide resolved
src/loki_cluster.py Show resolved Hide resolved
src/loki_cluster.py Show resolved Hide resolved
Copy link
Contributor

@sed-i sed-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good enough to merge for now.
I imagine we could have a few breaking changes soon after.

src/charm.py Show resolved Hide resolved
src/loki.py Outdated Show resolved Hide resolved
src/loki_cluster.py Show resolved Hide resolved
src/loki_cluster.py Show resolved Hide resolved
@Abuelodelanada Abuelodelanada merged commit ea451ff into main Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants