github: Extended testing #11846
Merged
github: Extended testing #11846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
force-pushed
the
tp-gh-setup-go
branch
2 times, most recently
from
baf63d5 to
dcd01c8
Compare
tomponline
changed the title
…k_space Signed-off-by: Thomas Parrott <[email protected]>
tomponline
force-pushed
the
tp-gh-setup-go
branch
6 times, most recently
from
b1d3de4 to
5f02e25
Compare
tomponline
changed the title
Allows opportunistic usage of dependency caching. Signed-off-by: Thomas Parrott <[email protected]>
To allow caching to work if available. Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
…alysis to Code tests Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
tomponline
force-pushed
the
tp-gh-setup-go
branch
from
5f02e25 to
fac5de4
Compare
Try and fix intermittent log matching issue. Signed-off-by: Thomas Parrott <[email protected]>
simondeziel
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
LGTM. Looking at previous test runs, btrfs usually is faster in either standalone, or cluster or sometimes both and by ~2-3 minutes. When btrfs isn't faster than dir, it usually is within a minute of dir.
That's the "CI minutes" aspect of the storage driver, maybe you picked dir for a specific reason.
|
Yes there isn't much in it. I picked dir because its what we do now, and is the least "exotic" of the storage drivers (also its the default one used if not specified). |
stgraber
reviewed
Jun 19, 2023
stgraber
reviewed
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dirdriver.