Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include h3 in table of contents WD-17309 MAASENG-4219 #830

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ndv99
Copy link
Collaborator

@ndv99 ndv99 commented Jan 8, 2025

Done

  • Included H3 headings in the generated table of contents for each page of docs

[List of work items including drive-bys]

QA

  • Go to /docs/reference-installation-requirements
  • Ensure H3 headings show in the table of contents at the top:
    • "Getting information using psql"
    • "Getting information via configuration file"
    • "Increasing maximum connections"
    • "Symptoms of an issue"

[List of steps to QA the new features or prove the bug has been resolved]

Issue / Card

Resolves MAASENG-4219
Resolves WD-17309

Screenshots

Before

image

After

image

[if relevant, include a screenshot]

@ndv99 ndv99 requested a review from petesfrench January 8, 2025 09:15
@webteam-app
Copy link

Copy link
Contributor

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for picking this up.

@ndv99 ndv99 merged commit d8413b0 into canonical:main Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants