Ceph: Add interactive and preseed options to configure a dedicated Ceph network in MicroCloud #274

gabrielmougard · 2024-04-02T14:25:23Z

See https://discourse.ubuntu.com/t/add-options-for-configuring-a-dedicated-ceph-network-in-microcloud/43687
JIRA ticket: https://warthogs.atlassian.net/jira/software/c/projects/LXD/boards/54?assignee=63d9eb6128cddcc70770aff1&selectedIssue=LXD-636

Bootstrapping with a dedicated Ceph Network
Adding new cluster members to a cluster with an existing dedicated Ceph network
- If the new cluster members have the right physical network interfaces with IPs that are within the subnet, it should work. Else, error out.

microcloud/go.mod

sabaini

Generally lgtm, two comments below.

As a heads-up separating public and cluster nets for Ceph was a relatively frequently requested feature so I wonder if this should be really conflated (will add to the spec as well).

microcloud/cmd/microcloud/main_init.go

doc/.wordlist.txt

doc/explanation/microcloud.rst

doc/tutorial/get_started.rst

gabrielmougard · 2024-04-12T15:55:30Z

@markylaing @masnax @ru-fu ready for review :)

ru-fu

This looks really good for the documentation already! A few more changes needed though (of course 😉 ).

doc/explanation/microcloud.rst

doc/how-to/ceph_networking.rst

doc/tutorial/get_started.rst

gabrielmougard · 2024-04-16T13:21:31Z

@ru-fu doc udpated

microcloud/cmd/microcloud/main_init.go

markylaing

Overall it looks really good :)

One thing that's missing though are some tests. Is that something you would be able to incorporate?

microcloud/service/lxd.go

microcloud/cmd/microcloud/main_init.go

markylaing

Looks great 😃. Lots of docs and tests. I just have one comment and one nit.

service/lxd.go

test/includes/microcloud.sh

masnax · 2024-06-06T01:50:43Z

@gabrielmougard

I seem to be consistently seeing this error at the same spot: https://github.com/canonical/microcloud/actions/runs/9347254250/job/25868665575?pr=274#step:13:9857

Error: failed to fetch cluster config: Get "http://control.socket/1.0/services/microceph/1.0/configs?target=10.186.56.49": EOF, Key:

gabrielmougard · 2024-06-06T12:39:06Z

@gabrielmougard

I seem to be consistently seeing this error at the same spot: https://github.com/canonical/microcloud/actions/runs/9347254250/job/25868665575?pr=274#step:13:9857
Error: failed to fetch cluster config: Get "http://control.socket/1.0/services/microceph/1.0/configs?target=10.186.56.49": EOF, Key: 

working on it.

service/microceph.go

gabrielmougard · 2024-06-07T22:43:41Z

@masnax tests should be passing

markylaing

A few nits but other than that it looks good to go :)

service/lxd.go

cmd/microcloud/main_init.go

doc/.wordlist.txt

Signed-off-by: Gabriel Mougard <[email protected]>

This defines the validation rules for a Ceph subnet string given a set of physical network interfaces. Signed-off-by: Gabriel Mougard <[email protected]>

When a Ceph cluster is deployed, we need to be able to query its global configuration. For example, we'll need this client logic to know if a deployed Ceph cluster has an existing `cluster_network` parameter. This will be required for adding a new cluster member using the dedicated Ceph subnet. Signed-off-by: Gabriel Mougard <[email protected]>

…itSystem Signed-off-by: Gabriel Mougard <[email protected]>

Signed-off-by: Gabriel Mougard <[email protected]>

…twork The added logic handle the bootstrapping and adding logic, when a dedicated Ceph network has been required. Signed-off-by: Gabriel Mougard <[email protected]>

…roCeph service If a dedicated Ceph network has been required, we choose this subnet for the `cluster` traffic. Signed-off-by: Gabriel Mougard <[email protected]>

Signed-off-by: Gabriel Mougard <[email protected]>

gabrielmougard · 2024-06-10T12:29:06Z

@markylaing updated

markylaing

LGTM thanks :)

masnax

We can finally put this one to rest :)

gabrielmougard requested review from tomponline, masnax, roosterfish and markylaing as code owners April 2, 2024 14:25

tomponline reviewed Apr 2, 2024

View reviewed changes

microcloud/go.mod Outdated Show resolved Hide resolved

gabrielmougard force-pushed the feat/ceph-dedicated-nets branch 7 times, most recently from 1dc28b2 to 6bf4b4f Compare April 3, 2024 18:14

gabrielmougard requested review from tomponline and simondeziel April 3, 2024 18:14

gabrielmougard force-pushed the feat/ceph-dedicated-nets branch 2 times, most recently from e61f999 to 617159b Compare April 4, 2024 16:20

gabrielmougard self-assigned this Apr 4, 2024

sabaini reviewed Apr 5, 2024

View reviewed changes

microcloud/cmd/microcloud/main_init.go Outdated Show resolved Hide resolved

microcloud/cmd/microcloud/main_init.go Outdated Show resolved Hide resolved

gabrielmougard force-pushed the feat/ceph-dedicated-nets branch from 617159b to 2d012fb Compare April 8, 2024 08:01

ru-fu reviewed Apr 12, 2024

View reviewed changes

doc/.wordlist.txt Outdated Show resolved Hide resolved

doc/explanation/microcloud.rst Outdated Show resolved Hide resolved

doc/tutorial/get_started.rst Outdated Show resolved Hide resolved

doc/tutorial/get_started.rst Outdated Show resolved Hide resolved

gabrielmougard force-pushed the feat/ceph-dedicated-nets branch 2 times, most recently from 9769473 to a173647 Compare April 12, 2024 15:53

gabrielmougard requested review from sabaini and ru-fu April 12, 2024 15:55

ru-fu reviewed Apr 15, 2024

View reviewed changes

gabrielmougard force-pushed the feat/ceph-dedicated-nets branch from a173647 to 85b44a1 Compare April 16, 2024 13:20

markylaing reviewed Apr 16, 2024

View reviewed changes

microcloud/cmd/microcloud/main_init.go Outdated Show resolved Hide resolved

markylaing requested changes Apr 16, 2024

View reviewed changes

microcloud/service/lxd.go Outdated Show resolved Hide resolved

microcloud/service/lxd.go Outdated Show resolved Hide resolved

microcloud/cmd/microcloud/main_init.go Outdated Show resolved Hide resolved

markylaing reviewed May 28, 2024

View reviewed changes

service/lxd.go Outdated Show resolved Hide resolved

test/includes/microcloud.sh Outdated Show resolved Hide resolved

gabrielmougard force-pushed the feat/ceph-dedicated-nets branch from bc146a2 to 725e276 Compare June 3, 2024 08:44

gabrielmougard mentioned this pull request Jun 3, 2024

Enable support for setting a Ceph public_network in the MicroCloud initialization #314

Closed

2 tasks

gabrielmougard force-pushed the feat/ceph-dedicated-nets branch from 725e276 to 723e771 Compare June 3, 2024 08:58

gabrielmougard force-pushed the feat/ceph-dedicated-nets branch 2 times, most recently from 3d5269c to 04b91a6 Compare June 7, 2024 18:36

github-advanced-security bot found potential problems Jun 7, 2024

View reviewed changes

service/microceph.go Dismissed Show dismissed Hide dismissed

gabrielmougard force-pushed the feat/ceph-dedicated-nets branch from 04b91a6 to 03103ad Compare June 7, 2024 19:16

gabrielmougard requested review from markylaing, masnax and tomponline June 10, 2024 07:15

markylaing requested changes Jun 10, 2024

View reviewed changes

service/lxd.go Outdated Show resolved Hide resolved

service/lxd.go Outdated Show resolved Hide resolved

service/lxd.go Outdated Show resolved Hide resolved

cmd/microcloud/main_init.go Show resolved Hide resolved

doc/.wordlist.txt Outdated Show resolved Hide resolved

gabrielmougard added 10 commits June 10, 2024 14:03

microcloud/service/lxd: GetCephInterfaces function

6a3ac62

Signed-off-by: Gabriel Mougard <[email protected]>

microcloud/service/lxd: Add ValidateCephInterfaces

cbc8227

This defines the validation rules for a Ceph subnet string given a set of physical network interfaces. Signed-off-by: Gabriel Mougard <[email protected]>

microcloud/cmd/microcloud: Add MicroCephInternalNetworkSubnet to In…

4051030

…itSystem Signed-off-by: Gabriel Mougard <[email protected]>

microcloud/cmd/microcloud: fix comments format

7ba4acf

Signed-off-by: Gabriel Mougard <[email protected]>

microcloud/cmd/microcloud: Ceph dedicated network interactive setup

c4ad62f

Signed-off-by: Gabriel Mougard <[email protected]>

microcloud/cmd/microcloud: Preseed logic to setup a dedicated Ceph ne…

21144a7

…twork The added logic handle the bootstrapping and adding logic, when a dedicated Ceph network has been required. Signed-off-by: Gabriel Mougard <[email protected]>

microcloud/cmd/microcloud: Apply Ceph dedicated network config to Mic…

40c4fd7

…roCeph service If a dedicated Ceph network has been required, we choose this subnet for the `cluster` traffic. Signed-off-by: Gabriel Mougard <[email protected]>

doc: Add documentation on how to set up a dedicated Ceph cluster network

f60d9f3

Signed-off-by: Gabriel Mougard <[email protected]>

microcloud/test: Add integration tests for Ceph networking

e25100b

Signed-off-by: Gabriel Mougard <[email protected]>

gabrielmougard force-pushed the feat/ceph-dedicated-nets branch from 03103ad to e25100b Compare June 10, 2024 12:20

markylaing approved these changes Jun 11, 2024

View reviewed changes

masnax approved these changes Jun 11, 2024

View reviewed changes

masnax merged commit 06766fe into canonical:main Jun 11, 2024
14 of 15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ceph: Add interactive and preseed options to configure a dedicated Ceph network in MicroCloud #274

Ceph: Add interactive and preseed options to configure a dedicated Ceph network in MicroCloud #274

gabrielmougard commented Apr 2, 2024 •

edited

Loading

sabaini left a comment

gabrielmougard commented Apr 12, 2024

ru-fu left a comment

gabrielmougard commented Apr 16, 2024

markylaing left a comment

markylaing left a comment

masnax commented Jun 6, 2024

gabrielmougard commented Jun 6, 2024

gabrielmougard commented Jun 7, 2024

markylaing left a comment

gabrielmougard commented Jun 10, 2024

markylaing left a comment

masnax left a comment

Ceph: Add interactive and preseed options to configure a dedicated Ceph network in MicroCloud #274

Ceph: Add interactive and preseed options to configure a dedicated Ceph network in MicroCloud #274

Conversation

gabrielmougard commented Apr 2, 2024 • edited Loading

sabaini left a comment

Choose a reason for hiding this comment

gabrielmougard commented Apr 12, 2024

ru-fu left a comment

Choose a reason for hiding this comment

gabrielmougard commented Apr 16, 2024

markylaing left a comment

Choose a reason for hiding this comment

markylaing left a comment

Choose a reason for hiding this comment

masnax commented Jun 6, 2024

gabrielmougard commented Jun 6, 2024

gabrielmougard commented Jun 7, 2024

markylaing left a comment

Choose a reason for hiding this comment

gabrielmougard commented Jun 10, 2024

markylaing left a comment

Choose a reason for hiding this comment

masnax left a comment

Choose a reason for hiding this comment

gabrielmougard commented Apr 2, 2024 •

edited

Loading