Fix storage filter restrictions #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roosterfish
requested changes
Dec 13, 2024
|
Merging the other preseed related PR has now caused a conflict. Requires rebase. |
…d disks Signed-off-by: Max Asnaashari <[email protected]>
masnax
force-pushed
the
fix-filter
branch
2 times, most recently
from
43610af to
4ec6f62
Compare
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storage selection filtering mechanism in preseed is meant as an alternative to the explicitly defined disk set.
If all systems have supplied disks explicitly for ceph, then also using the filter will now return a descriptive error, instead of simply reporting that no more disks could be found. The same is true for zfs.
Disk filtering will apply for any system that did not explicitly define disks. That is to say, as long as one system has not explicitly defined disks, then including a filter will be valid. This is true for ceph/zfs respectively.