Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service: Exlude disks of type cdrom #576

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

roosterfish
Copy link
Contributor

When creating local and remote storage pools the list of disks should not contain any cdrom drive.

Fixes #566

@roosterfish roosterfish requested a review from masnax January 7, 2025 10:30
@roosterfish
Copy link
Contributor Author

roosterfish commented Jan 7, 2025

I was testing this with https://en.wikipedia.org/wiki/CDemu. My first though was just filter out read-only drives but as you could potentially use the drive to write to the CD the rom drive itself isn't ro.

@roosterfish
Copy link
Contributor Author

@masnax it looks after 1/stable got updated the preseed cmd fails (e.g. https://github.com/canonical/microcloud/actions/runs/12649784309/job/35247023464?pr=576).

Did a bit of digging and it looks we are missing at least the first commit of the latest-candidate cherry picks in the packaging repo in the v1-candidate branch.

@masnax
Copy link
Contributor

masnax commented Jan 7, 2025

@masnax it looks after 1/stable got updated the preseed cmd fails (e.g. https://github.com/canonical/microcloud/actions/runs/12649784309/job/35247023464?pr=576).

Did a bit of digging and it looks we are missing at least the first commit of the latest-candidate cherry picks in the packaging repo in the v1-candidate branch.

I'm a bit confused how this ever worked because MicroCloud at v1 does not support reading preseed from stdin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device cdrom should not be listed as a deployment target
2 participants