-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Candidate cherry picks (v1-edge) #577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masnax
force-pushed
the
candidate-cherry-picks
branch
from
January 7, 2025 16:32
69c47d7
to
fdfbdb9
Compare
Signed-off-by: Max Asnaashari <[email protected]> (cherry picked from commit e50cd00)
Signed-off-by: Max Asnaashari <[email protected]> (cherry picked from commit b1553cb)
Signed-off-by: Max Asnaashari <[email protected]> (cherry picked from commit 404827f)
Signed-off-by: Max Asnaashari <[email protected]> (cherry picked from commit 00d6fca)
Signed-off-by: Max Asnaashari <[email protected]> (cherry picked from commit 6700eab)
Signed-off-by: Max Asnaashari <[email protected]> (cherry picked from commit 201968e)
…working questions Signed-off-by: Max Asnaashari <[email protected]> (cherry picked from commit 71567ea)
Signed-off-by: Max Asnaashari <[email protected]> (cherry picked from commit 283efac)
Signed-off-by: Max Asnaashari <[email protected]> (cherry picked from commit 4e0da91)
Signed-off-by: Max Asnaashari <[email protected]> (cherry picked from commit 88c7ef7)
…e interfaces Lookup was recently updated to lookup mDNS records via a particular interface, but the mDNS broadcasts were always coming from the default interface, even when advertising a different interface, so the lookup would ignore these records as they aren't coming from an interface that it expected. Signed-off-by: Max Asnaashari <[email protected]> (cherry picked from commit f19707a)
Signed-off-by: Max Asnaashari <[email protected]>
masnax
force-pushed
the
candidate-cherry-picks
branch
from
January 7, 2025 16:33
fdfbdb9
to
676bfcc
Compare
roosterfish
approved these changes
Jan 7, 2025
Probably worth a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the cherry picks from https://github.com/canonical/microcloud-pkg-snap/blob/4816c5e5bacbfa6c4a79267479fe1db6f88724ff/snapcraft.yaml#L102-L114 in the
v1-edge
branch.