Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decoration-strategy-rework #3712

Merged
merged 14 commits into from
Jan 30, 2025
Merged

decoration-strategy-rework #3712

merged 14 commits into from
Jan 30, 2025

Conversation

AlanGriffiths
Copy link
Collaborator

@AlanGriffiths AlanGriffiths commented Jan 7, 2025 •
edited
Loading

Improves the interface between the decoration strategies and the rest of the subsystem:

  1. Encapsulates the StaticGeometry
  2. Moves the Button enums into the struct (with a few renames)
  3. Adds some documentation
  4. Simplifies buffer creation API
  5. Make InputState a struct
  6. Simplify use of WindowState

Generally, making the decoration strategy simpler and easier to customise

@AlanGriffiths AlanGriffiths mentioned this pull request Jan 7, 2025
Merged
Base automatically changed from decoration-strategy to main January 14, 2025 08:17
@AlanGriffiths AlanGriffiths force-pushed the decoration-strategy-rework branch from 5cdf5aa to 9198dac Compare January 24, 2025 17:39
@AlanGriffiths AlanGriffiths force-pushed the decoration-strategy-rework branch from 9198dac to 5560f22 Compare January 27, 2025 17:53
@AlanGriffiths AlanGriffiths force-pushed the decoration-strategy-rework branch from 5560f22 to b58389b Compare January 28, 2025 11:37
@AlanGriffiths AlanGriffiths marked this pull request as ready for review January 28, 2025 11:41
@AlanGriffiths AlanGriffiths requested a review from a team as a code owner January 28, 2025 11:41
mattkae
mattkae approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a sensible moving around of things. I just have the one nit

src/server/shell/decoration/window.cpp Show resolved Hide resolved
@Saviq
Copy link
Collaborator

Saviq commented Jan 28, 2025

Is this time to add documentation for how shell devs can customize server-side decorations?

Or will this come next, when we actually start exposing it?

@AlanGriffiths
Copy link
Collaborator Author

Is this time to add documentation for how shell devs can customize server-side decorations?

Or will this come next, when we actually start exposing it?

Exactly, this is just moving towards an API we feel like supporting

tarek-y-ismail
tarek-y-ismail approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@tarek-y-ismail tarek-y-ismail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are consolidating nicely :)

@tarek-y-ismail tarek-y-ismail added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 5e15fde Jan 30, 2025
38 of 64 checks passed
@tarek-y-ismail tarek-y-ismail deleted the decoration-strategy-rework branch January 30, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkae mattkae mattkae approved these changes

@tarek-y-ismail tarek-y-ismail tarek-y-ismail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlanGriffiths @Saviq @mattkae @tarek-y-ismail