platforms/atomic-kms: Fix cursors across multiple monitors. #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`KMSOutput::has_cursor` was misleadingly named, and so we implemented it incorrectly. It is *used* to tell whether or not a cursor image needs to be set on that particular output before it is visible, *not* whether that output *supports* a cursor. Rename it to something hopefully more easily understandable, and then fix the implementation. Fixes: #3677
AlanGriffiths
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KMSOutput::has_cursorwas misleadingly named, and so we implemented it incorrectly. It is used to tell whether or not a cursor image needs to be set on that particular output before it is visible, not whether that output supports a cursor.Rename it to something hopefully more easily understandable, and then fix the implementation.
Fixes: #3677