Refactor charmcraft.yaml files to use python plugin and st124 notation
#424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3.x/edge, use branch for quality checks workflow with charmcraft 3.x/edge
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: OK
labels
…3.x/edge, use branch for quality checks workflow with charmcraft 3.x/edge
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
NohaIhab
reviewed
Jan 24, 2025
There was a problem hiding this comment.
thanks @misohu
charmcraft.yamls LGTM.
- Left you a comment to update the license
- Can you update the PR description to link to the relevant issues from this repo? e.g. Refactor the CI to use to data platform workflows for building charms #421
…3.x/edge, use branch for quality checks workflow with charmcraft 3.x/edge
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
misohu
changed the base branch from
KF-6684-refactor-ci-with-build
to
KF-6217-use-cache-builds-dev-branch
misohu
merged commit c062bc6
into
KF-6217-use-cache-builds-dev-branch
18 of 20 checks passed
misohu
added a commit
that referenced
this pull request
Feb 3, 2025
* Refactor charmcraft.yaml files to use `python` plugin and `st124` notation (#424)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #421
Note to reviewer: the bundle integration tests are failing due to charmcraft 3.x/edge not working correctly with parallel builds, this will be resolved once canonical/kfp-operators#645 is merged, where charmcraftcache is being used so the issue is no longer present.
PR is pointing to the dev brach KF-6217-use-cache-builds-dev-branch, so it is expected to be merged in red