Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate test repo #1793

Merged
merged 13 commits into from
Jun 4, 2024
Merged

Use separate test repo #1793

merged 13 commits into from
Jun 4, 2024

Conversation

cbartz
Copy link
Collaborator

@cbartz cbartz commented Jun 3, 2024

Applicable spec: n/a

Overview

1 . Use a separate test repo to run integration tests.
2. Don't use CI token.
3. Don't delete forks after CI run.

Rationale

  1. Using the same repo prevents PR notifications to slack/mattermost, due to the spam that all PR's created by integration testing cause.
  2. CI token only has permissions for the same repo.
  3. Deleting forks after a CI run prevents concurrent runs (if there are multiple PRs at the same time).

Module Changes

n/a

Checklist

  • The contributing guide was applied
  • The documentation is generated using src-docs
  • The PR is tagged with appropriate label (urgent, trivial, complex)
  • Version has been incremented on pyproject.toml

No production code touched, so no need to increment the version.

@cbartz cbartz added the trivial label Jun 3, 2024
@cbartz cbartz changed the title WIP - Use separate test repo Use separate test repo Jun 4, 2024
@cbartz cbartz marked this pull request as ready for review June 4, 2024 07:05
@cbartz cbartz requested a review from a team as a code owner June 4, 2024 07:05
Copy link
Contributor

@jdkandersson jdkandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cbartz cbartz merged commit 1ae7342 into main Jun 4, 2024
9 checks passed
@cbartz cbartz deleted the chore/separate-test-repo branch June 4, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants