Integrate with Starbase

rockcraft/cli.py

@@ -39,7 +39,7 @@ def run() -> int:
     return app.run()
 
 
-def _create_app():
+def _create_app():  # noqa: ANN202
     # pylint: disable=import-outside-toplevel
     # Import these here so that the script that generates the docs for the
     # commands doesn't need to know *too much* of the application.

rockcraft/commands/extensions.py

@@ -57,7 +57,7 @@ class ListExtensionsCommand(AppCommand, abc.ABC):
     )
 
     @overrides
-    def run(self, parsed_args: argparse.Namespace):
+    def run(self, parsed_args: argparse.Namespace) -> None:
         """Print the list of available extensions and their bases."""
         extension_presentation: dict[str, ExtensionModel] = {}
 
@@ -95,7 +95,7 @@ class ExpandExtensionsCommand(AppCommand, abc.ABC):
     )
 
     @overrides
-    def run(self, parsed_args: argparse.Namespace):
+    def run(self, parsed_args: argparse.Namespace) -> None:
         """Print the project's specification with the extensions expanded."""
         project = Project.unmarshal(load_project(Path("rockcraft.yaml")))
 

rockcraft/extensions/_utils.py

@@ -79,7 +79,10 @@ def _apply_extension(
         parts[part_name] = parts_snippet[part_name]
 
 
-def _apply_extension_property(existing_property: Any, extension_property: Any) -> Any:
+def _apply_extension_property(
+    existing_property: list[Any] | dict[str, Any] | None,
+    extension_property: list[Any] | dict[str, Any],
+) -> list[Any] | dict[str, Any] | None:
     if existing_property:
         # If the property is not scalar, merge them
         if isinstance(existing_property, list) and isinstance(extension_property, list):

rockcraft/models/project.py

@@ -200,7 +200,9 @@ def _validate_title(cls, title: str | None, values: Mapping[str, Any]) -> str:
 
     @pydantic.validator("build_base", always=True)
     @classmethod
-    def _validate_build_base(cls, build_base: str | None, values: Any) -> str:
+    def _validate_build_base(
+        cls, build_base: str | None, values: dict[str, Any]
+    ) -> str:
         """Build-base defaults to the base value if not specified.
 
         :raises ProjectValidationError: If base validation fails.
@@ -306,7 +308,9 @@ def _validate_parts(cls, item: dict[str, Any]) -> dict[str, Any]:
 
     @pydantic.validator("parts", each_item=True)
     @classmethod
-    def _validate_base_and_overlay(cls, item: dict[str, Any], values) -> dict[str, Any]:
+    def _validate_base_and_overlay(
+        cls, item: dict[str, Any], values: dict[str, Any]
+    ) -> dict[str, Any]:
         """Projects with "bare" bases cannot use overlays."""
         if values.get("base") == "bare" and part_has_overlay(item):
             raise ProjectValidationError(
@@ -317,7 +321,7 @@ def _validate_base_and_overlay(cls, item: dict[str, Any], values) -> dict[str, A
     @pydantic.validator("entrypoint_service")
     @classmethod
     def _validate_entrypoint_service(
-        cls, entrypoint_service: str | None, values: Any
+        cls, entrypoint_service: str | None, values: dict[str, Any]
     ) -> str | None:
         """Verify that the entrypoint_service exists in the services dict."""
         craft_cli.emit.message(
@@ -398,7 +402,7 @@ def _forbid_env_var_bash_interpolation(
     def to_yaml(self) -> str:
         """Dump this project as a YAML string."""
 
-        def _repr_str(dumper, data):
+        def _repr_str(dumper: yaml.SafeDumper, data: str) -> yaml.ScalarNode:
             """Multi-line string representer for the YAML dumper."""
             if "\n" in data:
                 return dumper.represent_scalar("tag:yaml.org,2002:str", data, style="|")

rockcraft/services/lifecycle.py

@@ -18,13 +18,14 @@
 
 import contextlib
 from pathlib import Path
-from typing import cast
+from typing import Any, cast
 
 from craft_application import LifecycleService
 from craft_archives import repo
 from craft_cli import emit
-from craft_parts import Features, Step, callbacks
+from craft_parts import Features, LifecycleManager, Step, callbacks
 from craft_parts.errors import CallbackRegistrationError
+from craft_parts.infos import ProjectInfo
 from overrides import override
 
 from rockcraft import layers
@@ -83,7 +84,10 @@ def run(self, step_name: str | None, part_names: list[str] | None = None) -> Non
             callbacks.unregister_all()
 
 
-def _install_package_repositories(package_repositories, lifecycle_manager) -> None:
+def _install_package_repositories(
+    package_repositories: list[dict[str, Any]] | None,
+    lifecycle_manager: LifecycleManager,
+) -> None:
     """Install package repositories in the environment."""
     if not package_repositories:
         emit.debug("No package repositories specified, none to install.")
@@ -97,7 +101,7 @@ def _install_package_repositories(package_repositories, lifecycle_manager) -> No
     emit.progress("Package repositories installed")
 
 
-def _install_overlay_repositories(overlay_dir, project_info):
+def _install_overlay_repositories(overlay_dir: Path, project_info: ProjectInfo) -> None:
     if project_info.base != "bare":
         package_repositories = project_info.package_repositories
         repo.install_in_root(