Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init script: create link for .wokeignore #136

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

ru-fu
Copy link
Contributor

@ru-fu ru-fu commented Oct 25, 2023

When running woke locally, the .wokeignore file must be in the folder where you run it (for example, the docs folder). When runnin on GitHub, we run woke from the root folder though, and it cannot deal with a .wokeignore file in a subdirectory. Therefore, have the script create a symlink (unless there already is a .wokeignore file in the root folder).

init.sh Show resolved Hide resolved
@pmatulis
Copy link

And don't we need to make an analogous change in the manual steps?

When running woke locally, the .wokeignore file must be in the
folder where you run it (for example, the `docs` folder).
When running on GitHub, we run woke from the root folder though,
and it cannot deal with a .wokeignore file in a subdirectory.
Therefore, have the script create a symlink (unless there already
is a .wokeignore file in the root folder).

Signed-off-by: Ruth Fuchss <[email protected]>
@ru-fu
Copy link
Contributor Author

ru-fu commented Oct 31, 2023

Thanks for the review @pmatulis ! Updated now.

Copy link

@pmatulis pmatulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍇 🍍

@pmatulis pmatulis merged commit 2cde7d5 into canonical:main Oct 31, 2023
1 check passed
@ru-fu ru-fu deleted the fix-wokeignore branch October 31, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants