Add new Ubuntu variable font to custom CSS #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ru-fu
reviewed
Jan 5, 2024
.sphinx/_static/custom.css
Outdated
| unicode-range: U+0100-024F, U+1E00-1EFF, U+20A0-20AB, U+20AD-20CF, U+2C60-2C7F, U+A720-A7FF; | ||
| } | ||
|
|
||
|
|
||
| /** Fix the font weight (300 for normal, 400 for slightly bold) **/ |
There was a problem hiding this comment.
Do these font weights still make sense, or should it be 400 for normal text and 550 for bold now?
There was a problem hiding this comment.
Good catch. It needs to be adjusted, at least for the code blocks. I'll also have a look at other common text elements.
ru-fu
approved these changes
Jan 5, 2024
|
Apart from the font itself the typography could use some adjustments towards Vanilla (font sizes, margins, etc), but should be fine as is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
@font-facedefinitions based on Vanilla to include latest Ubuntu variable web font, and uses this font in font config. This should fix the issue with wrong weight of the Ubuntu font and align this better with Vanilla styling.Part of WEBDOC-7