Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove init script, replace init-based testing #314

Merged
merged 24 commits into from
Dec 9, 2024
Merged

remove init script, replace init-based testing #314

merged 24 commits into from
Dec 9, 2024

Conversation

akcano
Copy link
Contributor

@akcano akcano commented Dec 5, 2024 •
edited
Loading

This does the following:

  • drops the init.sh script logic
  • merges sp-files and sp-docs
  • simplifies testing logic
  • merges Makefile and Makefile.sp

This does not alter the SP documentation significantly; the manual workflow should be documented separately after the details of this PR are polished.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Make sure to keep .github/workflows/automatic-doc-checks.yml and sp-files/.github/workflows/automatic-doc-checks.yml in sync!

3 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Make sure to keep .github/workflows/automatic-doc-checks.yml and sp-files/.github/workflows/automatic-doc-checks.yml in sync!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Make sure to keep .github/workflows/automatic-doc-checks.yml and sp-files/.github/workflows/automatic-doc-checks.yml in sync!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Make sure to keep .github/workflows/automatic-doc-checks.yml and sp-files/.github/workflows/automatic-doc-checks.yml in sync!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Make sure to keep .github/workflows/automatic-doc-checks.yml and sp-files/.github/workflows/automatic-doc-checks.yml in sync!

@akcano akcano changed the title WIP: Feature/initless remove init script, replace init-based testing Dec 5, 2024
@akcano akcano marked this pull request as ready for review December 5, 2024 20:58
@akcano akcano requested a review from minaelee December 5, 2024 20:59
SecondSkoll
SecondSkoll approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@SecondSkoll SecondSkoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Needs some minor changes and a conflict resolution apparently.

I think we'll need to rethink how actions work, as we now have local and remote actions - but I don't want that to block this.

.github/workflows/periodic-style-checks.yml Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
docs/content/doc-cheat-sheet-myst.md Outdated Show resolved Hide resolved
docs/content/doc-cheat-sheet.rst Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Make sure to keep .github/workflows/automatic-doc-checks.yml and sp-files/.github/workflows/automatic-doc-checks.yml in sync!

3 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Make sure to keep .github/workflows/automatic-doc-checks.yml and sp-files/.github/workflows/automatic-doc-checks.yml in sync!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Make sure to keep .github/workflows/automatic-doc-checks.yml and sp-files/.github/workflows/automatic-doc-checks.yml in sync!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Make sure to keep .github/workflows/automatic-doc-checks.yml and sp-files/.github/workflows/automatic-doc-checks.yml in sync!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Make sure to keep .github/workflows/automatic-doc-checks.yml and sp-files/.github/workflows/automatic-doc-checks.yml in sync!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Make sure to keep .github/workflows/automatic-doc-checks.yml and sp-files/.github/workflows/automatic-doc-checks.yml in sync!

edibotopic
edibotopic approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@edibotopic edibotopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, Artem: LGTM.

@akcano akcano requested review from izmalk and removed request for minaelee December 6, 2024 19:21
@akcano akcano merged commit 47f5d3e into canonical:main Dec 9, 2024
6 checks passed
@akcano akcano deleted the feature/initless branch December 9, 2024 12:54
@akcano akcano mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SecondSkoll SecondSkoll SecondSkoll approved these changes

@edibotopic edibotopic edibotopic approved these changes

@izmalk izmalk Awaiting requested review from izmalk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akcano @edibotopic @SecondSkoll